Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2359)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsVariationParameters.java

Issue 2782233002: Drop ntp_snippets::kStudyName in chrome://flags (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsVariationParameters.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsVariationParameters.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsVariationParameters.java
index 67bf0a134f5188ceb18f4b67da158716e8d7b4ad..154a25c6dee799b93d632a670c2ba7e4991d550a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsVariationParameters.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardsVariationParameters.java
@@ -23,7 +23,6 @@ public final class CardsVariationParameters {
private static final String TAG = "CardsVariationParams";
// Also defined in ntp_snippets_constants.cc
- private static final String FIELD_TRIAL_NAME_MAIN = "NTPSnippets";
private static final String FIELD_TRIAL_NAME_VISIBILITY = "NTPSnippetsVisibility";
private static final String PARAM_FAVICON_SERVICE_NAME = "favicons_fetch_from_service";
@@ -38,6 +37,9 @@ public final class CardsVariationParameters {
private static final int FIRST_CARD_ANIMATION_DEFAULT_VALUE = 7;
+ // TODO(sfiera): replace with feature-specific field trials, as has been done in C++.
+ private static final String FIELD_TRIAL_NAME_MAIN = "NTPSnippets";
+
private CardsVariationParameters() {}
// TODO(jkrcal): Do a proper general fix in VariationsAssociatedData in the spirit of
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698