[Bindings] Move and remove some private symbols from V8HiddenValue

Moves following symbols from V8HiddenValue to V8PrivateProperty
- customElementAttachedCallback
- customElementAttributeChangedCallback
- customElementCreatedCallback
- customElementDetachedCallback
- customElementsRegistryMap
- idbCursorRequest
- internalBodyBuffer
- internalBodyStream
- requestInFetchEvent
- toStringString

and removes following symbols, which are not used.
- testInterfaces
- thenableHiddenPromise
- injectedScriptNative


BUG=611864
Review-Url: https://codereview.chromium.org/2777943005
Cr-Commit-Position: refs/heads/master@{#462071}
Committed: https://chromium.googlesource.com/chromium/src/+/2acaf7f8acf2931db3d91fa51a2dd0a0e2d0481f

[peria, 2017-03-29 05:45:10]

Patchset #1 (id:1) has been deleted

[peria, 2017-03-29 05:49:37]

Description was changed from

==========
move many items



BUG=
==========

to

==========
Move following symbols from V8HiddenValue to V8PrivateProperty
- customElementAttachedCallback
- customElementAttributeChangedCallback
- customElementCreatedCallback
- customElementDetachedCallback
- customElementsRegistryMap
- idbCursorRequest
- internalBodyBuffer
- internalBodyStream
- requestInFetchEvent
- toStringString

and removed following symbols, which are not used.
- testInterfaces
- thenableHiddenPromise
- injectedScriptNative


BUG=611864
==========

[peria, 2017-03-29 05:50:31]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[peria, 2017-03-29 05:50:48]

peria@chromium.org changed reviewers:
+ haraken@chromium.org, yukishiino@chromium.org

[peria, 2017-03-29 05:50:48]

PTL

[commit-bot: I haz the power, 2017-03-29 05:50:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-03-29 05:54:22]

Description was changed from

==========
Move following symbols from V8HiddenValue to V8PrivateProperty
- customElementAttachedCallback
- customElementAttributeChangedCallback
- customElementCreatedCallback
- customElementDetachedCallback
- customElementsRegistryMap
- idbCursorRequest
- internalBodyBuffer
- internalBodyStream
- requestInFetchEvent
- toStringString

and removed following symbols, which are not used.
- testInterfaces
- thenableHiddenPromise
- injectedScriptNative


BUG=611864
==========

to

==========
Moves following symbols from V8HiddenValue to V8PrivateProperty
- customElementAttachedCallback
- customElementAttributeChangedCallback
- customElementCreatedCallback
- customElementDetachedCallback
- customElementsRegistryMap
- idbCursorRequest
- internalBodyBuffer
- internalBodyStream
- requestInFetchEvent
- toStringString

and removes following symbols, which are not used.
- testInterfaces
- thenableHiddenPromise
- injectedScriptNative


BUG=611864
==========

[commit-bot: I haz the power, 2017-03-29 06:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 06:21:35]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[peria, 2017-03-29 07:07:37]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 07:08:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 07:38:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 07:39:00]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Yuki, 2017-03-29 12:36:05]

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
(right):

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp:65:
//    Audit the use of hidden values in general and how the map is
nit: s/hidden values/private properties/

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp (right):

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp:121:
v8SetReturnValue(info, V8PrivateProperty::getToStringString(isolate).get(
s/get/getOrUndefined/

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h (right):

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:54:
X(RequestInFetch, Event)                            \
X(FetchEvent, Request)

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:59: X(ToString,
String)                                 \
X(LazyEventListener, ToString)
or
X(LazyEventListener, ToStringString)

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:116:
v8::Local<v8::Value> get(v8::Local<v8::Context> context,
Not related to this CL, but just FYI.

Now I think that this signature is not a good design after I learnt about realm
/ v8::Context.  As I explained somewhere else, we should use the current context
for v8::Object::GetPrivate, etc.

Then, taking a context as an argument is simply redundant in best case, and it's
wrong in worst case that the caller passes a wrong context.

V8PrivateProperty::getFooBar(isolate) takes an isolate as the argument, so we
can keep that isolate in V8PrivateProperty::Symbol together with v8::Private. 
Then, we can use isolate->GetCurrentContext() unconditionally inside
hasValue/get/getOrUndefined/set APIs.

This change makes the call sites a lot simpler and also makes things correct.

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
(right):

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp:67:
DCHECK(symbol##Name.hasValue(context, prototype));      \
DCHECK(!hasValue);

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp:69:
symbol##Name.set(context, prototype, Value.ToLocalChecked());
This pattern looks a bit strange.  Should be:

  v8::Local<v8::Value> value;
  if (Maybe.ToLocal(value))
    symbol##Name.set(context, prototype, value);

where Value is renamed to Maybe because it conflicts v8::Value.

[peria, 2017-03-30 09:30:03]

Patchset #3 (id:60001) has been deleted

[peria, 2017-03-30 09:30:16]

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
(right):

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp:65:
//    Audit the use of hidden values in general and how the map is
On 2017/03/29 12:36:05, Yuki wrote:
> nit: s/hidden values/private properties/

Done.

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp (right):

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp:121:
v8SetReturnValue(info, V8PrivateProperty::getToStringString(isolate).get(
On 2017/03/29 12:36:05, Yuki wrote:
> s/get/getOrUndefined/

Done.

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h (right):

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:54:
X(RequestInFetch, Event)                            \
On 2017/03/29 12:36:05, Yuki wrote:
> X(FetchEvent, Request)

Done.

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:59: X(ToString,
String)                                 \
On 2017/03/29 12:36:05, Yuki wrote:
> X(LazyEventListener, ToString)
> or
> X(LazyEventListener, ToStringString)

Done.

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:116:
v8::Local<v8::Value> get(v8::Local<v8::Context> context,
On 2017/03/29 12:36:05, Yuki wrote:
> Not related to this CL, but just FYI.
> 
> Now I think that this signature is not a good design after I learnt about
realm
> / v8::Context.  As I explained somewhere else, we should use the current
context
> for v8::Object::GetPrivate, etc.
> 
> Then, taking a context as an argument is simply redundant in best case, and
it's
> wrong in worst case that the caller passes a wrong context.
> 
> V8PrivateProperty::getFooBar(isolate) takes an isolate as the argument, so we
> can keep that isolate in V8PrivateProperty::Symbol together with v8::Private. 
> Then, we can use isolate->GetCurrentContext() unconditionally inside
> hasValue/get/getOrUndefined/set APIs.
> 
> This change makes the call sites a lot simpler and also makes things correct.

Acknowledged.
Done in https://codereview.chromium.org/2785943002/

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
(right):

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp:67:
DCHECK(symbol##Name.hasValue(context, prototype));      \
On 2017/03/29 12:36:05, Yuki wrote:
> DCHECK(!hasValue);

Done.

https://codereview.chromium.org/2777943005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp:69:
symbol##Name.set(context, prototype, Value.ToLocalChecked());
On 2017/03/29 12:36:05, Yuki wrote:
> This pattern looks a bit strange.  Should be:
> 
>   v8::Local<v8::Value> value;
>   if (Maybe.ToLocal(value))
>     symbol##Name.set(context, prototype, value);
> 
> where Value is renamed to Maybe because it conflicts v8::Value.

Done.

[peria, 2017-03-30 09:30:23]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 09:30:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2017-03-30 09:36:08]

LGTM.

https://codereview.chromium.org/2777943005/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
(right):

https://codereview.chromium.org/2777943005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp:37:
v8::Local<v8::Value> map = symbol.getOrEmpty(wrapper);
nit: We can use

map = symbol.getOrUndefined(wrapper)

and

if (map->IsUndefined()) { ... }

[peria, 2017-03-30 10:27:12]

https://codereview.chromium.org/2777943005/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
(right):

https://codereview.chromium.org/2777943005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp:37:
v8::Local<v8::Value> map = symbol.getOrEmpty(wrapper);
On 2017/03/30 09:36:08, Yuki wrote:
> nit: We can use
> 
> map = symbol.getOrUndefined(wrapper)
> 
> and
> 
> if (map->IsUndefined()) { ... }

Done.

[peria, 2017-03-30 10:32:43]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 10:32:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 11:47:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 11:47:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-03-30 14:04:46]

LGTM

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
(right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp:38:
if (map->IsUndefined()) {

As I commented in the other CL, I'd prefer removing getOrUndefined and unify to
getOrEmpty().

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
(right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp:69:
if (Maybe.ToLocal(&function))                         \

Can we use ToLocalChecked?

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.cpp:733:
.set(request.As<v8::Object>(), bodyBuffer);

This private property is set but never get.

Is it probably used to keep alive the body buffer? If that is the case, we
should replace it with the wrapper tracing. You don't need to address it in this
CL though.

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Response.cpp (right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Response.cpp:459:
.set(response.As<v8::Object>(), bodyBuffer);

Ditto.

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp (right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp:97: wrapper,
ToV8(m_request.get(), wrapper, isolate));

Ditto.

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp (right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp:101:
.set(event.As<v8::Object>(), request);

Ditto.

[peria, 2017-04-04 05:48:36]

Patchset #5 (id:120001) has been deleted

[peria, 2017-04-04 05:48:58]

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
(right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp:38:
if (map->IsUndefined()) {
On 2017/03/30 14:04:45, haraken wrote:
> 
> As I commented in the other CL, I'd prefer removing getOrUndefined and unify
to
> getOrEmpty().

Acknowledged.

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
(right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp:69:
if (Maybe.ToLocal(&function))                         \
On 2017/03/30 14:04:45, haraken wrote:
> 
> Can we use ToLocalChecked?

Done.

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.cpp:733:
.set(request.As<v8::Object>(), bodyBuffer);
On 2017/03/30 14:04:45, haraken wrote:
> 
> This private property is set but never get.
> 
> Is it probably used to keep alive the body buffer? If that is the case, we
> should replace it with the wrapper tracing. You don't need to address it in
this
> CL though.

Those private properties you commented on seem to be used
to keep other wrappers alive.
I'll do it in another CL.

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Response.cpp (right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Response.cpp:459:
.set(response.As<v8::Object>(), bodyBuffer);
On 2017/03/30 14:04:45, haraken wrote:
> 
> Ditto.

Acknowledged.

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp (right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp:97: wrapper,
ToV8(m_request.get(), wrapper, isolate));
On 2017/03/30 14:04:45, haraken wrote:
> 
> Ditto.

Acknowledged.

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp (right):

https://codereview.chromium.org/2777943005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp:101:
.set(event.As<v8::Object>(), request);
On 2017/03/30 14:04:45, haraken wrote:
> 
> Ditto.

Acknowledged.

[peria, 2017-04-04 06:13:45]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 06:14:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 06:52:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 06:52:16]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[peria, 2017-04-05 09:48:25]

Patchset #6 (id:160001) has been deleted

[peria, 2017-04-05 09:48:34]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 09:48:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-04-05 09:57:02]

PTAL, just in case.

https://codereview.chromium.org/2777943005/diff/140001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
(right):

https://codereview.chromium.org/2777943005/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp:67:
symbol##Name.set(prototype, Maybe.ToLocalChecked());
This change triggered many layout test failures, so reverted.

https://codereview.chromium.org/2777943005/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h (right):

https://codereview.chromium.org/2777943005/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:24: //
FetchEvent.Request.
Add a TODO comment not to leave those private properties.

[Yuki, 2017-04-05 10:42:19]

LGTM.

[commit-bot: I haz the power, 2017-04-05 12:26:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 12:26:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[peria, 2017-04-05 13:51:54]

The CQ bit was checked by peria@chromium.org

[peria, 2017-04-05 13:51:54]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2777943005/#ps180001
(title: "Fix test failures")

[commit-bot: I haz the power, 2017-04-05 13:52:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 14:59:07]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1491400314003810,
"parent_rev": "7576d8453c3b3147136b19180fbf10464d22be07", "commit_rev":
"2acaf7f8acf2931db3d91fa51a2dd0a0e2d0481f"}

[commit-bot: I haz the power, 2017-04-05 15:00:02]

Description was changed from

==========
Moves following symbols from V8HiddenValue to V8PrivateProperty
- customElementAttachedCallback
- customElementAttributeChangedCallback
- customElementCreatedCallback
- customElementDetachedCallback
- customElementsRegistryMap
- idbCursorRequest
- internalBodyBuffer
- internalBodyStream
- requestInFetchEvent
- toStringString

and removes following symbols, which are not used.
- testInterfaces
- thenableHiddenPromise
- injectedScriptNative


BUG=611864
==========

to

==========
Moves following symbols from V8HiddenValue to V8PrivateProperty
- customElementAttachedCallback
- customElementAttributeChangedCallback
- customElementCreatedCallback
- customElementDetachedCallback
- customElementsRegistryMap
- idbCursorRequest
- internalBodyBuffer
- internalBodyStream
- requestInFetchEvent
- toStringString

and removes following symbols, which are not used.
- testInterfaces
- thenableHiddenPromise
- injectedScriptNative


BUG=611864

Review-Url: https://codereview.chromium.org/2777943005
Cr-Commit-Position: refs/heads/master@{#462071}
Committed:
https://chromium.googlesource.com/chromium/src/+/2acaf7f8acf2931db3d91fa51a2d...
==========

[commit-bot: I haz the power, 2017-04-05 15:00:03]

Committed patchset #6 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/2acaf7f8acf2931db3d91fa51a2d...