Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

Issue 2777943005: [Bindings] Move and remove some private symbols from V8HiddenValue (Closed)
Patch Set: Fix test failures Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
index 2ba65e34fc12199b292af3c46b44d949dfcb2c13..6f112cf5db67d317517f77b9b02090e7aba1ed43 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
@@ -19,6 +19,9 @@ namespace blink {
class ScriptWrappable;
+// TODO(peria): Remove properties just to keep V8 objects alive.
+// e.g. InternalBody.Buffer, InternalBody.Stream, IDBCursor.Request,
+// FetchEvent.Request.
peria 2017/04/05 09:57:02 Add a TODO comment not to leave those private prop
// Apply |X| for each pair of (InterfaceName, PrivateKeyName).
#define V8_PRIVATE_PROPERTY_FOR_EACH(X) \
X(CustomElement, AdoptedCallback) \
@@ -28,14 +31,24 @@ class ScriptWrappable;
X(CustomElement, Document) \
X(CustomElement, IsInterfacePrototypeObject) \
X(CustomElement, NamespaceURI) \
+ X(CustomElement, RegistryMap) \
X(CustomElement, TagName) \
X(CustomElement, Type) \
+ X(CustomElementLifecycle, AttachedCallback) \
+ X(CustomElementLifecycle, AttributeChangedCallback) \
+ X(CustomElementLifecycle, CreatedCallback) \
+ X(CustomElementLifecycle, DetachedCallback) \
X(CustomEvent, Detail) \
X(DOMException, Error) \
X(ErrorEvent, Error) \
+ X(FetchEvent, Request) \
X(Global, Event) \
+ X(IDBCursor, Request) \
X(IDBObserver, Callback) \
+ X(InternalBody, Buffer) \
+ X(InternalBody, Stream) \
X(IntersectionObserver, Callback) \
+ X(LazyEventListener, ToString) \
X(MessageChannel, Port1) \
X(MessageChannel, Port2) \
X(MessageEvent, CachedData) \

Powered by Google App Engine
This is Rietveld 408576698