[ESLint] Fix violations when enabling curly rule in eslint.

[ESLint] Fix violations when enabling curly rule in eslint.

curly rule enabled:

"curly": ["error", "multi-line", "consistent"]

The --fix option in eslint converts code from:
  if (a < b)
    return true;
to:
  if (a < b) {return true;}

which is not right for our codebase. Eventually we want code like:
  if (a < b) return true;
if it can fit in one line. This patch will need a follow-up patch to clean up
code from:
  if (a < b) {
    return true;
  }
to:
  if (a < b) return true;

BUG=catapult:#3322

Review-Url: https://codereview.chromium.org/2776653002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/da45b1a5fb8ba558ac13173813beb6b88b84328d

[lpy, 2017-03-24 07:46:30]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 07:46:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2017-03-24 07:53:51]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 07:54:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2017-03-24 07:58:45]

lpy@chromium.org changed reviewers:
+ benjhayden@chromium.org, charliea@chromium.org, sullivan@chromium.org

[lpy, 2017-03-24 07:58:48]

PTAL.

[commit-bot: I haz the power, 2017-03-24 08:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 08:21:27]

Dry run: This issue passed the CQ dry run.

[sullivan, 2017-03-24 12:49:53]

Thanks for doing this! I posted a style question on the linked bug.

/dashboard and / lgtm after resolving style question

[lpy, 2017-03-24 18:28:34]

Description was changed from

==========
[ESLint] Fix violation when enabling curly rule in eslint.

curly rule enabled:

"curly": ["error", "multi-line", "consistent"]

BUG=catapult:#3322
==========

to

==========
[ESLint] Fix violation when enabling curly rule in eslint.

curly rule enabled:

"curly": ["error", "multi-line", "consistent"]

The --fix option in eslint converts code from:
  if (a < b)
    return true;
to:
  if (a < b) {return true;}

which is not right for our codebase. Eventually we want code like:
  if (a < b) return true;
if it can fit in one line. This patch will need a follow-up patch to clean up
code from:
  if (a < b) {
    return true;
  }
to:
  if (a < b) return true;

BUG=catapult:#3322
==========

[charliea (OOO until 10-5), 2017-03-27 15:33:39]

lgtm for tracing/

Thanks for taking this on @lpy! This seems like a sane intermediate step to me.

[charliea (OOO until 10-5), 2017-03-27 15:35:58]

Ah, one last thing: could you change the subject and description to say "Fix
violations" instead of "Fix violation"? The idea that there was only one
violation threw me for a loop when reading the CL description :-)

[lpy, 2017-03-27 17:13:39]

Description was changed from

==========
[ESLint] Fix violation when enabling curly rule in eslint.

curly rule enabled:

"curly": ["error", "multi-line", "consistent"]

The --fix option in eslint converts code from:
  if (a < b)
    return true;
to:
  if (a < b) {return true;}

which is not right for our codebase. Eventually we want code like:
  if (a < b) return true;
if it can fit in one line. This patch will need a follow-up patch to clean up
code from:
  if (a < b) {
    return true;
  }
to:
  if (a < b) return true;

BUG=catapult:#3322
==========

to

==========
[ESLint] Fix violations when enabling curly rule in eslint.

curly rule enabled:

"curly": ["error", "multi-line", "consistent"]

The --fix option in eslint converts code from:
  if (a < b)
    return true;
to:
  if (a < b) {return true;}

which is not right for our codebase. Eventually we want code like:
  if (a < b) return true;
if it can fit in one line. This patch will need a follow-up patch to clean up
code from:
  if (a < b) {
    return true;
  }
to:
  if (a < b) return true;

BUG=catapult:#3322
==========

[lpy, 2017-03-27 17:14:24]

On 2017/03/27 15:35:58, charliea wrote:
> Ah, one last thing: could you change the subject and description to say "Fix
> violations" instead of "Fix violation"? The idea that there was only one
> violation threw me for a loop when reading the CL description :-)

Done.

[benjhayden, 2017-03-27 18:15:00]

I don't see any `if (a < b) {return true;} ` in this CL. Is the CL description
still accurate?

https://codereview.chromium.org/2776653002/diff/10001/dashboard/dashboard/ele...
File dashboard/dashboard/elements/alerts-table.html (right):

https://codereview.chromium.org/2776653002/diff/10001/dashboard/dashboard/ele...
dashboard/dashboard/elements/alerts-table.html:555: unitName = '(unformatted)';
Looks like lots of branches where this CL added braces should fit on previous
line?

[lpy, 2017-03-27 18:26:39]

On 2017/03/27 18:15:00, benjhayden wrote:
> I don't see any `if (a < b) {return true;} ` in this CL. Is the CL description
> still accurate?

Yes, because I didn't use --fix, and I randomly changed code that would fit to
one line to

if (a < b) {
  return true;
}

>
https://codereview.chromium.org/2776653002/diff/10001/dashboard/dashboard/ele...
> File dashboard/dashboard/elements/alerts-table.html (right):
> 
>
https://codereview.chromium.org/2776653002/diff/10001/dashboard/dashboard/ele...
> dashboard/dashboard/elements/alerts-table.html:555: unitName =
'(unformatted)';
> Looks like lots of branches where this CL added braces should fit on previous
> line?

Indeed, I didn't notice that we should always make sure if the code could fit in
one line, we make it in one line.

So in this CL, code like

if (a < b)
  return true;

was changed to

if (a < b) {
  return true;
}

or

if (a < b) return true;

[benjhayden, 2017-03-27 18:38:15]

lgtm, thanks!

[lpy, 2017-03-27 19:31:03]

The CQ bit was checked by lpy@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:31:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 19:34:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:34:31]

Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[lpy, 2017-03-27 20:16:57]

The CQ bit was checked by lpy@chromium.org

[lpy, 2017-03-27 20:16:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org, benjhayden@chromium.org, charliea@chromium.org
Link to the patchset: https://codereview.chromium.org/2776653002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-27 20:17:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 20:43:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490645817051770,
"parent_rev": "9edcf25d881b9a947b477a3401c25b599caacc39", "commit_rev":
"da45b1a5fb8ba558ac13173813beb6b88b84328d"}

[commit-bot: I haz the power, 2017-03-27 20:43:51]

Description was changed from

==========
[ESLint] Fix violations when enabling curly rule in eslint.

curly rule enabled:

"curly": ["error", "multi-line", "consistent"]

The --fix option in eslint converts code from:
  if (a < b)
    return true;
to:
  if (a < b) {return true;}

which is not right for our codebase. Eventually we want code like:
  if (a < b) return true;
if it can fit in one line. This patch will need a follow-up patch to clean up
code from:
  if (a < b) {
    return true;
  }
to:
  if (a < b) return true;

BUG=catapult:#3322
==========

to

==========
[ESLint] Fix violations when enabling curly rule in eslint.

curly rule enabled:

"curly": ["error", "multi-line", "consistent"]

The --fix option in eslint converts code from:
  if (a < b)
    return true;
to:
  if (a < b) {return true;}

which is not right for our codebase. Eventually we want code like:
  if (a < b) return true;
if it can fit in one line. This patch will need a follow-up patch to clean up
code from:
  if (a < b) {
    return true;
  }
to:
  if (a < b) return true;

BUG=catapult:#3322

Review-Url: https://codereview.chromium.org/2776653002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-03-27 20:43:53]

Committed patchset #3 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...