Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html

Issue 2776653002: [ESLint] Fix violations when enabling curly rule in eslint. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html
diff --git a/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html b/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html
index 4af662874e91d1c88f606d323b14c683bb716789..1f1fcfc1dd8edbc5bcaffc1e03174711e55e963e 100644
--- a/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html
+++ b/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html
@@ -80,23 +80,26 @@ tr.b.unittest.testSuite(function() {
expectedContexts) {
// Check title.
var formattedTitle = columns[0].formatTitle(row);
- if (typeof expectedTitle === 'function')
+ if (typeof expectedTitle === 'function') {
expectedTitle(formattedTitle);
- else
+ } else {
assert.strictEqual(formattedTitle, expectedTitle);
+ }
// Check all sizes. The first assert below is a test sanity check.
assert.lengthOf(expectedSizes, columns.length - 1 /* all except title */);
- for (var i = 0; i < expectedSizes.length; i++)
+ for (var i = 0; i < expectedSizes.length; i++) {
checkSizeNumericFields(row, columns[i + 1], expectedSizes[i]);
+ }
// There should be no row nesting on the overview pane.
assert.isUndefined(row.subRows);
- if (expectedContexts)
+ if (expectedContexts) {
assert.deepEqual(tr.b.asArray(row.contexts), expectedContexts);
- else
+ } else {
assert.isUndefined(row.contexts);
+ }
}
function checkRows(columns, actualRows, expectedRows) {
@@ -404,10 +407,11 @@ tr.b.unittest.testSuite(function() {
assert.strictEqual(
table.selectedColumnIndex, expectedSelectedColumnIndex);
- if (expectedSelectedRowTitle === undefined)
+ if (expectedSelectedRowTitle === undefined) {
assert.isUndefined(table.selectedTableRow);
- else
+ } else {
assert.equal(table.selectedTableRow.title, expectedSelectedRowTitle);
+ }
callback(viewEl, viewEl.$.table);
}
@@ -611,8 +615,9 @@ tr.b.unittest.testSuite(function() {
checkOverviewColumnInfosAndColor(c,
fieldAndDumpMask,
function(pmd, mask) {
- if (mask & HAS_OWN_VM_REGIONS)
+ if (mask & HAS_OWN_VM_REGIONS) {
pmd.vmRegions = [];
+ }
},
expectedInfos,
expectedIsOlderColor ?
@@ -691,10 +696,12 @@ tr.b.unittest.testSuite(function() {
checkOverviewColumnInfosAndColor(c,
fieldAndDumpMask,
function(pmd, mask) {
- if (mask & HAS_HEAP_DUMPS)
+ if (mask & HAS_HEAP_DUMPS) {
pmd.heapDumps = {};
- if (mask & HAS_ALLOCATOR_HEAP_DUMP)
+ }
+ if (mask & HAS_ALLOCATOR_HEAP_DUMP) {
pmd.heapDumps['Allocator'] = new HeapDump(pmd, 'Allocator');
+ }
var mad = new MemoryAllocatorDump(pmd, 'Allocator');
if (!(mask & MISSING_SIZE)) {
mad.addNumeric('size',

Powered by Google App Engine
This is Rietveld 408576698