tracing/tracing/extras/importer/trace2html_importer.html - Issue 2776653002: [ESLint] Fix violations when enabling curly rule in eslint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/extras/importer/trace2html_importer.html

Issue 2776653002: [ESLint] Fix violations when enabling curly rule in eslint. (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/extras/importer/trace2html_importer.html

diff --git a/tracing/tracing/extras/importer/trace2html_importer.html b/tracing/tracing/extras/importer/trace2html_importer.html

index 5009b553aaf93a9b3b9cdafab7c7571e3565f541..d39308dcdf6ea31f9cbcadf305f6ff94409ebbad 100644

--- a/tracing/tracing/extras/importer/trace2html_importer.html

+++ b/tracing/tracing/extras/importer/trace2html_importer.html

@@ -30,12 +30,12 @@ tr.exportTo('tr.e.importer', function() {

while (true) {

if (!r.advanceToLineMatching(

new RegExp('^<\s*script id="viewer-data" ' +

- 'type="(application\/json|text\/plain)">$')))

+ 'type="(application\/json|text\/plain)">$'))) {

break;

+ }

r.beginSavingLines();

- if (!r.advanceToLineMatching(/^<\/\s*script>$/))

- return;

+ if (!r.advanceToLineMatching(/^<\/\s*script>$/)) return;

var rawEvents = r.endSavingLinesAndGetResult();

@@ -50,13 +50,11 @@ tr.exportTo('tr.e.importer', function() {

}

function _canImportFromHTML(text) {

- if (!/^<!DOCTYPE html>/.test(text))

- return false;

+ if (!/^<!DOCTYPE html>/.test(text)) return false;

// Try to find viewer-data...

_extractEventsFromHTML(text);

- if (Trace2HTMLImporter.subtraces_.length === 0)

- return false;

+ if (Trace2HTMLImporter.subtraces_.length === 0) return false;

return true;

}