tracing/tracing/ui/analysis/multi_event_sub_view.html - Issue 2776653002: [ESLint] Fix violations when enabling curly rule in eslint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/multi_event_sub_view.html

Issue 2776653002: [ESLint] Fix violations when enabling curly rule in eslint. (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/ui/analysis/multi_event_sub_view.html

diff --git a/tracing/tracing/ui/analysis/multi_event_sub_view.html b/tracing/tracing/ui/analysis/multi_event_sub_view.html

index a33b3b4586a65e51fe005d3599a4d9f313c5e3fa..9306ba5beb77bf1af7c2a23ddedace32525703ab 100644

--- a/tracing/tracing/ui/analysis/multi_event_sub_view.html

+++ b/tracing/tracing/ui/analysis/multi_event_sub_view.html

@@ -80,8 +80,7 @@ tr.exportTo('tr.ui.analysis', function() {

var diagnostics = {};

for (var item of EVENT_FIELD) {

var fieldName = item.key;

- if (slice[fieldName] === undefined)

- continue;

+ if (slice[fieldName] === undefined) continue;

diagnostics[fieldName] = new tr.v.d.Scalar(new tr.b.Scalar(

tr.b.Unit.byName.timeDurationInMs, slice[fieldName]));

}

@@ -118,8 +117,9 @@ tr.exportTo('tr.ui.analysis', function() {

set selection(selection) {

- if (selection.length <= 1)

+ if (selection.length <= 1) {

throw new Error('Only supports multiple items');

+ }

this.setSelectionWithoutErrorChecks(selection);