Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: tracing/tracing/ui/analysis/memory_dump_sub_view_test_utils.html

Issue 2776653002: [ESLint] Fix violations when enabling curly rule in eslint. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/analysis/memory_dump_sub_view_test_utils.html
diff --git a/tracing/tracing/ui/analysis/memory_dump_sub_view_test_utils.html b/tracing/tracing/ui/analysis/memory_dump_sub_view_test_utils.html
index f2c454630a6d3a58341dc0dd1f401d04372ac40c..dc5cf5729e8ac36fd198db7d0027da429d7b861d 100644
--- a/tracing/tracing/ui/analysis/memory_dump_sub_view_test_utils.html
+++ b/tracing/tracing/ui/analysis/memory_dump_sub_view_test_utils.html
@@ -334,10 +334,11 @@ tr.exportTo('tr.ui.analysis', function() {
function checkNumericFields(row, column, expectedValues, expectedUnit) {
var fields;
- if (column === undefined)
+ if (column === undefined) {
fields = row;
- else
+ } else {
fields = column.fields(row);
+ }
if (expectedValues === undefined) {
assert.isUndefined(fields);
@@ -409,15 +410,17 @@ tr.exportTo('tr.ui.analysis', function() {
column, fields, contexts, expectedInfos, expectedColorReservedName) {
// Test sanity checks.
assert.isDefined(fields);
- if (contexts !== undefined)
+ if (contexts !== undefined) {
assert.lengthOf(contexts, fields.length);
+ }
// Check infos.
var infos = [];
column.addInfos(fields, contexts, infos);
assert.lengthOf(infos, expectedInfos.length);
- for (var i = 0; i < expectedInfos.length; i++)
+ for (var i = 0; i < expectedInfos.length; i++) {
assert.deepEqual(infos[i], expectedInfos[i]);
+ }
// Check color.
var actualColor = typeof column.color === 'function' ?
@@ -486,8 +489,7 @@ tr.exportTo('tr.ui.analysis', function() {
paneEl.createChildPane = function() {
var childPaneBuilder = this.childPaneBuilder;
- if (childPaneBuilder === undefined)
- return undefined;
+ if (childPaneBuilder === undefined) return undefined;
return childPaneBuilder();
};
@@ -498,8 +500,7 @@ tr.exportTo('tr.ui.analysis', function() {
function isElementDisplayed(element) {
var style = getComputedStyle(element);
var displayed = style['display'];
- if (displayed === undefined)
- return true;
+ if (displayed === undefined) return true;
return displayed.indexOf('none') === -1;
}
@@ -530,8 +531,7 @@ tr.exportTo('tr.ui.analysis', function() {
function extractVmRegions(processMemoryDumps, pid) {
return processMemoryDumps.map(function(memoryDumps) {
var processMemoryDump = memoryDumps[pid];
- if (processMemoryDump === undefined)
- return undefined;
+ if (processMemoryDump === undefined) return undefined;
return processMemoryDump.mostRecentVmRegions;
});
}
@@ -544,8 +544,7 @@ tr.exportTo('tr.ui.analysis', function() {
function extractMemoryAllocatorDumps(processMemoryDumps, pid, allocatorName) {
return processMemoryDumps.map(function(memoryDumps) {
var processMemoryDump = memoryDumps[pid];
- if (processMemoryDump === undefined)
- return undefined;
+ if (processMemoryDump === undefined) return undefined;
return processMemoryDump.getMemoryAllocatorDumpByFullName(allocatorName);
});
}
@@ -559,8 +558,9 @@ tr.exportTo('tr.ui.analysis', function() {
return processMemoryDumps.map(function(memoryDumps) {
var processMemoryDump = memoryDumps[pid];
if (processMemoryDump === undefined ||
- processMemoryDump.heapDumps === undefined)
+ processMemoryDump.heapDumps === undefined) {
return undefined;
+ }
return processMemoryDump.heapDumps[allocatorName];
});
}

Powered by Google App Engine
This is Rietveld 408576698