Prevent tests using data URLs from being broken by data URL deprecation

Prevent tests using data URLs from being broken by data URL deprecation

These test will be broken when content initiated top frame data
URL navigations are blocked. Move them away from data URLs.

BUG=594215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2772983003
Cr-Commit-Position: refs/heads/master@{#461184}
Committed: https://chromium.googlesource.com/chromium/src/+/86b0c6ec76fc6adfad37a4f22a500e89fa23175c

[meacer, 2017-03-24 20:27:10]

Description was changed from

==========
Prevent tests using data URLs from being broken by data URL deprecation

These test will be broken when content initiated top frame data
URL navigations are blocked. Move them away from data URLs.

BUG=594215
==========

to

==========
Prevent tests using data URLs from being broken by data URL deprecation

These test will be broken when content initiated top frame data
URL navigations are blocked. Move them away from data URLs.

BUG=594215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[meacer, 2017-03-24 20:27:21]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 20:28:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 21:37:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 21:37:33]

Dry run: This issue passed the CQ dry run.

[meacer, 2017-03-24 22:20:25]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 22:21:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meacer, 2017-03-24 22:35:58]

meacer@chromium.org changed reviewers:
+ boliu@chromium.org, msw@chromium.org, nasko@chromium.org

[meacer, 2017-03-24 22:35:58]

PTAL? Thanks.

msw: chrome/browser/ui/browser_browsertest.cc  
boliu: 
components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
nasko: content/browser/frame_host/navigation_controller_impl_browsertest.cc

[boliu, 2017-03-24 22:38:33]

On 2017/03/24 22:35:58, Mustafa Emre Acer wrote:
> PTAL? Thanks.
> 
> msw: chrome/browser/ui/browser_browsertest.cc  
> boliu: 
>
components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

I don't own that?

> nasko: content/browser/frame_host/navigation_controller_impl_browsertest.cc

[meacer, 2017-03-24 22:40:03]

On 2017/03/24 22:38:33, boliu wrote:
> On 2017/03/24 22:35:58, Mustafa Emre Acer wrote:
> > PTAL? Thanks.
> > 
> > msw: chrome/browser/ui/browser_browsertest.cc  
> > boliu: 
> >
>
components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
> 
> I don't own that?
> 
> > nasko: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Yes, sorry! :)

[meacer, 2017-03-24 22:40:43]

meacer@chromium.org changed reviewers:
+ melandory@chromium.org
- boliu@chromium.org

[meacer, 2017-03-24 22:40:44]

-boliu
+melandory for components/subresource_filter/content/

[commit-bot: I haz the power, 2017-03-24 23:36:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 23:36:02]

Dry run: This issue passed the CQ dry run.

[meacer, 2017-03-25 00:14:12]

meacer@chromium.org changed reviewers:
+ bauerb@chromium.org

[meacer, 2017-03-25 00:14:12]

msw/bauerb: Can also one of you PTAL at
chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc?

[msw, 2017-03-25 00:19:24]

c/b/ui/browser_browsertest.cc  lgtm

[msw, 2017-03-25 00:26:49]

popup_blocker_browsertest.cc is a bit less straightforward, but I suppose that
lgtm too, maybe bauerb can take a look there too.

[melandory, 2017-03-27 09:14:47]

Subresource_filter lgtm

[meacer, 2017-03-27 18:27:51]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 18:28:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meacer, 2017-03-27 18:31:00]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 18:31:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 18:35:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 18:35:30]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[meacer, 2017-03-27 21:24:31]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 21:25:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2017-03-27 21:39:19]

https://codereview.chromium.org/2772983003/diff/80001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2772983003/diff/80001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:516:
shell(), embedded_test_server()->GetURL("/simple_page.html?page1")));
Why not navigate to completely different pages? We have title[1-3].html.

https://codereview.chromium.org/2772983003/diff/80001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:6295:
"/simple_page.html#same-page-navigation")));
nit: same-document-navigation, we are phasing out the "same-page" wording in a
series of CLs.

[meacer, 2017-03-27 22:15:47]

https://codereview.chromium.org/2772983003/diff/80001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2772983003/diff/80001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:516:
shell(), embedded_test_server()->GetURL("/simple_page.html?page1")));
On 2017/03/27 21:39:19, nasko wrote:
> Why not navigate to completely different pages? We have title[1-3].html.

That's convenient :)

https://codereview.chromium.org/2772983003/diff/80001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:6295:
"/simple_page.html#same-page-navigation")));
On 2017/03/27 21:39:19, nasko wrote:
> nit: same-document-navigation, we are phasing out the "same-page" wording in a
> series of CLs.

Done.

[nasko, 2017-03-27 22:43:31]

lgtm

[Bernhard Bauer, 2017-03-28 15:07:19]

Description was changed from

==========
Prevent tests using data URLs from being broken by data URL deprecation

These test will be broken when content initiated top frame data
URL navigations are blocked. Move them away from data URLs.

BUG=594215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Prevent tests using data URLs from being broken by data URL deprecation

These test will be broken when content initiated top frame data
URL navigations are blocked. Move them away from data URLs.

BUG=594215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Bernhard Bauer, 2017-03-28 15:07:19]

bauerb@chromium.org changed reviewers:
- bauerb@chromium.org

[meacer, 2017-03-31 00:02:54]

The CQ bit was checked by meacer@chromium.org

[meacer, 2017-03-31 00:02:55]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
melandory@chromium.org
Link to the patchset: https://codereview.chromium.org/2772983003/#ps100001
(title: "nasko comments")

[commit-bot: I haz the power, 2017-03-31 00:04:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 00:57:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 00:57:59]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[meacer, 2017-03-31 18:31:08]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2017-03-31 18:31:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 19:40:36]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490985068937830,
"parent_rev": "d8b95960a8f2bec0e0eb48e636ee57204804bad9", "commit_rev":
"86b0c6ec76fc6adfad37a4f22a500e89fa23175c"}

[commit-bot: I haz the power, 2017-03-31 19:41:49]

Description was changed from

==========
Prevent tests using data URLs from being broken by data URL deprecation

These test will be broken when content initiated top frame data
URL navigations are blocked. Move them away from data URLs.

BUG=594215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Prevent tests using data URLs from being broken by data URL deprecation

These test will be broken when content initiated top frame data
URL navigations are blocked. Move them away from data URLs.

BUG=594215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2772983003
Cr-Commit-Position: refs/heads/master@{#461184}
Committed:
https://chromium.googlesource.com/chromium/src/+/86b0c6ec76fc6adfad37a4f22a50...
==========

[commit-bot: I haz the power, 2017-03-31 19:41:50]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/86b0c6ec76fc6adfad37a4f22a50...