chrome/test/data/popup_blocker/popup-fake-click-on-anchor3.html - Issue 2772983003: Prevent tests using data URLs from being broken by data URL deprecation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/popup_blocker/popup-fake-click-on-anchor3.html

Issue 2772983003: Prevent tests using data URLs from being broken by data URL deprecation (Closed)

Patch Set: nasko comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/popup_blocker/popup-fake-click-on-anchor3.html

diff --git a/chrome/test/data/popup_blocker/popup-fake-click-on-anchor3.html b/chrome/test/data/popup_blocker/popup-fake-click-on-anchor3.html

index ddc934393d6543081b19618061d328b027487fca..bab5b5a76d8cb935b4f9696b627d959000394136 100644

--- a/chrome/test/data/popup_blocker/popup-fake-click-on-anchor3.html

+++ b/chrome/test/data/popup_blocker/popup-fake-click-on-anchor3.html

@@ -9,7 +9,7 @@ function test() {

</script>

</head>

-If the fake click was not blocked then there will be an warning message displayed in a new tab. Otherwise, the test passes.

-<a href="data:text/html,<title>PASS</title>you should not see this message if popup blocker is enabled"></a>

+If the fake click was not blocked then there will be a warning message displayed in a new tab. Otherwise, the test passes.

+<a href="popup-success.html">link</a>

</body>

</html>