Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

Issue 2772983003: Prevent tests using data URLs from being broken by data URL deprecation (Closed)
Patch Set: nasko comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
index f02b9d69052df075b476390f98a369960a203b61..d20d2ae2b45b3c24eb19f690c224346b41daf01a 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
@@ -746,9 +746,11 @@ TEST_P(ContentSubresourceFilterDriverFactoryActivationScopeTest,
test_data.activation_scope,
kActivationListSocialEngineeringAdsInterstitial);
- const char* unsupported_urls[] = {
- "data:text/html,<p>Hello", "ftp://example.com/", "chrome://settings",
- "chrome-extension://some-extension", "file:///var/www/index.html"};
+ // data URLs are also not supported, but not listed here, as it's not possible
+ // for a page to redirect to them after https://crbug.com/594215 is fixed.
+ const char* unsupported_urls[] = {"ftp://example.com/", "chrome://settings",
+ "chrome-extension://some-extension",
+ "file:///var/www/index.html"};
const char* supported_urls[] = {"http://example.test",
"https://example.test"};
for (auto* url : unsupported_urls) {

Powered by Google App Engine
This is Rietveld 408576698