chrome/test/data/popup_blocker/popup-window-open-noopener.html - Issue 2772983003: Prevent tests using data URLs from being broken by data URL deprecation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/popup_blocker/popup-window-open-noopener.html

Issue 2772983003: Prevent tests using data URLs from being broken by data URL deprecation (Closed)

Patch Set: nasko comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!-- Copyright 2017 The Chromium Authors. All rights reserved.	1 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

2 Use of this source code is governed by a BSD-style license that can be	2 Use of this source code is governed by a BSD-style license that can be

3 found in the LICENSE file. -->	3 found in the LICENSE file. -->

4 <head>	4 <head>

5 <html>	5 <html>

6 <head>	6 <head>

7 <title>Popup created using window.open</title>	7 <title>Popup created using window.open</title>

8 <script>	8 <script>

9 function test() {	9 function test() {

10 window.open("data:text/html,<title>Popup Success!</title>" +	10 window.open("popup-success.html",

11 "you should not see this message if popup blocker is enabled",

12 "mywindow", "menubar=1, resizable=1, width=350, height=250, noopener");	11 "mywindow", "menubar=1, resizable=1, width=350, height=250, noopener");

13 }	12 }

14 </script>	13 </script>

15 </head>	14 </head>

16 <body onload="test()">	15 <body onload="test()">

17 pop-up test page	16 pop-up test page

18 </body>	17 </body>

19 </html>	18 </html>

OLD	NEW