chrome/test/data/popup_blocker/popup-window-open-noopener.html - Issue 2772983003: Prevent tests using data URLs from being broken by data URL deprecation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/popup_blocker/popup-window-open-noopener.html

Issue 2772983003: Prevent tests using data URLs from being broken by data URL deprecation (Closed)

Patch Set: nasko comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/popup_blocker/popup-window-open-noopener.html

diff --git a/chrome/test/data/popup_blocker/popup-window-open-noopener.html b/chrome/test/data/popup_blocker/popup-window-open-noopener.html

index 1a55bd2e2afde7ba8dd0a1cf8bf10ef90755d829..5fa86c113a9134ef7d5b3f87b2efc5b8b4e52e0c 100644

--- a/chrome/test/data/popup_blocker/popup-window-open-noopener.html

+++ b/chrome/test/data/popup_blocker/popup-window-open-noopener.html

@@ -7,8 +7,7 @@

<title>Popup created using window.open</title>

function test() {

- window.open("data:text/html,<title>Popup Success!</title>" +

- "you should not see this message if popup blocker is enabled",

+ window.open("popup-success.html",

"mywindow", "menubar=1, resizable=1, width=350, height=250, noopener");

}

</script>