Remove |use_fallback_path_| from WMPI

Remove |use_fallback_path_| from WMPI

Currently, WMPI chooses whether to use a MediaResource::Type::URL based
off of the explicit flag |use_fallback_path_|. This flag is only set at
WMPI creation time, in RenderFrameImpl. If the final redirected URL is
an HLS playlist, we request that WMPI be reloaded.

This CL changes WMPI to chose the MediaResource::Type based off of
RendererFactory::GetRequiredMediaResourceType(). This allows us to get
rid of |use_fallback_path_| and to update RendererFactorySelector after
redirects, rather than reloading WMPI.

BUG=663503
Review-Url: https://codereview.chromium.org/2769153005
Cr-Commit-Position: refs/heads/master@{#467428}
Committed: https://chromium.googlesource.com/chromium/src/+/75e2bf66ab653982229c116d96257daf71936b47

[tguilbert, 2017-04-25 01:04:11]

tguilbert@chromium.org changed reviewers:
+ dalecurtis@chromium.org, nick@chromium.org

[tguilbert, 2017-04-25 01:04:12]

PTAL!

nick@ can you owners review content/renderer/render_frame_impl.cc?

CC: avayvod@ as an FYI (I added you to a joint TODO)

Thank you!
Thomas

[DaleCurtis, 2017-04-25 16:36:34]

https://codereview.chromium.org/2769153005/diff/40001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (left):

https://codereview.chromium.org/2769153005/diff/40001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:1642:
client_->RequestReload(url_after_redirects);
Probably this API can be deleted in a future CL now?

https://codereview.chromium.org/2769153005/diff/40001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2769153005/diff/40001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:1636: if
(MediaCodecUtil::IsHLSURL(url_after_redirects)) {
A later change will switch this to also include the detected container type?
I.e. so no one can sneak any non-HLS types through this.

https://codereview.chromium.org/2769153005/diff/40001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:1734: if (data_source_) {
Drop {} from single-line if.

[tguilbert, 2017-04-25 20:22:32]

https://codereview.chromium.org/2769153005/diff/40001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (left):

https://codereview.chromium.org/2769153005/diff/40001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:1642:
client_->RequestReload(url_after_redirects);
On 2017/04/25 16:36:34, DaleCurtis wrote:
> Probably this API can be deleted in a future CL now?

You are right! I opened 715244 to track the work.

https://codereview.chromium.org/2769153005/diff/40001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2769153005/diff/40001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:1636: if
(MediaCodecUtil::IsHLSURL(url_after_redirects)) {
On 2017/04/25 16:36:34, DaleCurtis wrote:
> A later change will switch this to also include the detected container type?
> I.e. so no one can sneak any non-HLS types through this.

Yes. I already have most of the code written:
https://codereview.chromium.org/2770293002/

The CL needs to be rebased and cleaned up, and I need to fix some
inconsistencies. It will probably easier for me to formally add the
"stopping/stopped" state to PipelineController before submitting the above CL.

https://codereview.chromium.org/2769153005/diff/40001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:1734: if (data_source_) {
On 2017/04/25 16:36:34, DaleCurtis wrote:
> Drop {} from single-line if.

Done.

[DaleCurtis, 2017-04-25 20:33:53]

media/ lgtm then!  Thanks!

[tguilbert, 2017-04-26 00:12:20]

Patchset #5 (id:80001) has been deleted

[tguilbert, 2017-04-26 00:14:00]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 00:14:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 03:52:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 03:52:31]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[liberato (no reviews please), 2017-04-26 05:54:50]

liberato@chromium.org changed reviewers:
+ liberato@chromium.org

[liberato (no reviews please), 2017-04-26 05:54:50]

thanks
-fl

https://codereview.chromium.org/2769153005/diff/60001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.h (right):

https://codereview.chromium.org/2769153005/diff/60001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.h:667: bool using_media_player_renderer_;
= false?

[tguilbert, 2017-04-26 18:11:53]

https://codereview.chromium.org/2769153005/diff/60001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.h (right):

https://codereview.chromium.org/2769153005/diff/60001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.h:667: bool using_media_player_renderer_;
On 2017/04/26 05:54:50, liberato wrote:
> = false?

Done.

[tguilbert, 2017-04-26 18:12:03]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 18:12:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2017-04-26 19:27:18]

lgtm

[tguilbert, 2017-04-26 19:28:06]

The CQ bit was unchecked by tguilbert@chromium.org

[tguilbert, 2017-04-26 19:28:16]

The CQ bit was checked by tguilbert@chromium.org

[tguilbert, 2017-04-26 19:28:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2769153005/#ps120001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-04-26 19:29:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 20:13:16]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1493234896765810,
"parent_rev": "d65d570dafc96e2f12abe682c7148a350a94dc52", "commit_rev":
"75e2bf66ab653982229c116d96257daf71936b47"}

[commit-bot: I haz the power, 2017-04-26 20:13:35]

Description was changed from

==========
Remove |use_fallback_path_| from WMPI

Currently, WMPI chooses whether to use a MediaResource::Type::URL based
off of the explicit flag |use_fallback_path_|. This flag is only set at
WMPI creation time, in RenderFrameImpl. If the final redirected URL is
an HLS playlist, we request that WMPI be reloaded.

This CL changes WMPI to chose the MediaResource::Type based off of
RendererFactory::GetRequiredMediaResourceType(). This allows us to get
rid of |use_fallback_path_| and to update RendererFactorySelector after
redirects, rather than reloading WMPI.

BUG=663503
==========

to

==========
Remove |use_fallback_path_| from WMPI

Currently, WMPI chooses whether to use a MediaResource::Type::URL based
off of the explicit flag |use_fallback_path_|. This flag is only set at
WMPI creation time, in RenderFrameImpl. If the final redirected URL is
an HLS playlist, we request that WMPI be reloaded.

This CL changes WMPI to chose the MediaResource::Type based off of
RendererFactory::GetRequiredMediaResourceType(). This allows us to get
rid of |use_fallback_path_| and to update RendererFactorySelector after
redirects, rather than reloading WMPI.

BUG=663503

Review-Url: https://codereview.chromium.org/2769153005
Cr-Commit-Position: refs/heads/master@{#467428}
Committed:
https://chromium.googlesource.com/chromium/src/+/75e2bf66ab653982229c116d9625...
==========

[commit-bot: I haz the power, 2017-04-26 20:13:36]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/75e2bf66ab653982229c116d9625...