Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 2769153005: Remove |use_fallback_path_| from WMPI (Closed)
Patch Set: Addressed comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/renderer_factory_selector_unittest.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index dd29a3380a0b3edde32f29e22d49d386656f2a6b..de05e0946ce18f6974448dea3207343c157eba94 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -656,8 +656,15 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
// Used for HLS playback and in certain fallback paths (e.g. on older devices
// that can't support the unified media pipeline).
- GURL fallback_url_;
- bool use_fallback_path_;
+ GURL loaded_url_;
+
+ // NOTE: |using_media_player_renderer_| is set based on the usage of a
+ // MediaResource::Type::URL in StartPipeline(). This currently works because
+ // the MediaPlayerRendererClient factory is the only factory that returns that
+ // Type, but this may no longer be accurate when we remove |cast_impl_| and
+ // WebMediaPlayerCast. This flag should be renamed/updated accordingly when
+ // removing |cast_impl_|.
+ bool using_media_player_renderer_ = false;
// Called sometime after the media is suspended in a playing state in
// OnFrameHidden(), causing the state to change to paused.
« no previous file with comments | « media/base/renderer_factory_selector_unittest.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698