Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: media/base/renderer_factory_selector.cc

Issue 2769153005: Remove |use_fallback_path_| from WMPI (Closed)
Patch Set: Addressed comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/renderer_factory_selector.h" 5 #include "media/base/renderer_factory_selector.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace media { 9 namespace media {
10 10
11 RendererFactorySelector::RendererFactorySelector() {} 11 RendererFactorySelector::RendererFactorySelector() {}
12 12
13 RendererFactorySelector::~RendererFactorySelector() {} 13 RendererFactorySelector::~RendererFactorySelector() {}
14 14
15 void RendererFactorySelector::AddFactory( 15 void RendererFactorySelector::AddFactory(
16 FactoryType type, 16 FactoryType type,
17 std::unique_ptr<RendererFactory> factory) { 17 std::unique_ptr<RendererFactory> factory) {
18 DCHECK(!factories_[type]); 18 DCHECK(!factories_[type]);
19 19
20 factories_[type] = std::move(factory); 20 factories_[type] = std::move(factory);
21 } 21 }
22 22
23 void RendererFactorySelector::SetBaseFactoryType(FactoryType type) { 23 void RendererFactorySelector::SetBaseFactoryType(FactoryType type) {
24 DCHECK(factories_[type]); 24 DCHECK(factories_[type]);
25 base_factory_type_ = type; 25 base_factory_type_ = type;
26 current_factory_needs_update_ = true;
27 }
28
29 // For the moment, this method should only be called once or twice.
30 // This method will be regularly called whenever the logic in choosing a
31 // renderer type is moved out of the AdaptiveRendererFactory, into this method.
32 void RendererFactorySelector::UpdateCurrentFactory() {
33 DCHECK(base_factory_type_);
34 FactoryType next_factory_type = base_factory_type_.value();
35
36 if (use_media_player_)
37 next_factory_type = FactoryType::MEDIA_PLAYER;
38
39 DVLOG(1) << __func__ << " Selecting factory type: " << next_factory_type;
40
41 current_factory_ = factories_[next_factory_type].get();
42 current_factory_needs_update_ = false;
26 } 43 }
27 44
28 RendererFactory* RendererFactorySelector::GetCurrentFactory() { 45 RendererFactory* RendererFactorySelector::GetCurrentFactory() {
29 DCHECK(base_factory_type_); 46 if (current_factory_needs_update_)
30 FactoryType next_factory_type = base_factory_type_.value(); 47 UpdateCurrentFactory();
31 48
32 RendererFactory* factory = factories_[next_factory_type].get(); 49 DCHECK(current_factory_);
33 50 return current_factory_;
34 if (factory == nullptr) {
35 NOTREACHED();
36 return nullptr;
37 }
38
39 DVLOG(1) << __func__ << " Selected factory type: " << next_factory_type;
40
41 return factory;
42 } 51 }
43 52
53 #if defined(OS_ANDROID)
54 void RendererFactorySelector::SetUseMediaPlayer(bool use_media_player) {
55 use_media_player_ = use_media_player;
56 current_factory_needs_update_ = true;
57 }
58 #endif
59
44 } // namespace media 60 } // namespace media
OLDNEW
« no previous file with comments | « media/base/renderer_factory_selector.h ('k') | media/base/renderer_factory_selector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698