Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: media/base/renderer_factory_selector.cc

Issue 2769153005: Remove |use_fallback_path_| from WMPI (Closed)
Patch Set: Addressed comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/renderer_factory_selector.h ('k') | media/base/renderer_factory_selector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/renderer_factory_selector.cc
diff --git a/media/base/renderer_factory_selector.cc b/media/base/renderer_factory_selector.cc
index 49e3fce042ca9071af8622fd6d7b3f294434f939..3eb41fced272095dd0f017d5f20e22767959930b 100644
--- a/media/base/renderer_factory_selector.cc
+++ b/media/base/renderer_factory_selector.cc
@@ -23,22 +23,38 @@ void RendererFactorySelector::AddFactory(
void RendererFactorySelector::SetBaseFactoryType(FactoryType type) {
DCHECK(factories_[type]);
base_factory_type_ = type;
+ current_factory_needs_update_ = true;
}
-RendererFactory* RendererFactorySelector::GetCurrentFactory() {
+// For the moment, this method should only be called once or twice.
+// This method will be regularly called whenever the logic in choosing a
+// renderer type is moved out of the AdaptiveRendererFactory, into this method.
+void RendererFactorySelector::UpdateCurrentFactory() {
DCHECK(base_factory_type_);
FactoryType next_factory_type = base_factory_type_.value();
- RendererFactory* factory = factories_[next_factory_type].get();
+ if (use_media_player_)
+ next_factory_type = FactoryType::MEDIA_PLAYER;
+
+ DVLOG(1) << __func__ << " Selecting factory type: " << next_factory_type;
+
+ current_factory_ = factories_[next_factory_type].get();
+ current_factory_needs_update_ = false;
+}
- if (factory == nullptr) {
- NOTREACHED();
- return nullptr;
- }
+RendererFactory* RendererFactorySelector::GetCurrentFactory() {
+ if (current_factory_needs_update_)
+ UpdateCurrentFactory();
- DVLOG(1) << __func__ << " Selected factory type: " << next_factory_type;
+ DCHECK(current_factory_);
+ return current_factory_;
+}
- return factory;
+#if defined(OS_ANDROID)
+void RendererFactorySelector::SetUseMediaPlayer(bool use_media_player) {
+ use_media_player_ = use_media_player;
+ current_factory_needs_update_ = true;
}
+#endif
} // namespace media
« no previous file with comments | « media/base/renderer_factory_selector.h ('k') | media/base/renderer_factory_selector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698