Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: media/blink/webmediaplayer_impl.h

Issue 2769153005: Remove |use_fallback_path_| from WMPI (Closed)
Patch Set: Addressed comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/base/renderer_factory_selector_unittest.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_ 5 #ifndef MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
6 #define MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_ 6 #define MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 // Suppresses calls to OnPipelineError() after destruction / shutdown has been 649 // Suppresses calls to OnPipelineError() after destruction / shutdown has been
650 // started; prevents us from spuriously logging errors that are transient or 650 // started; prevents us from spuriously logging errors that are transient or
651 // unimportant. 651 // unimportant.
652 bool suppress_destruction_errors_; 652 bool suppress_destruction_errors_;
653 653
654 // If true, the media pipeline can be suspended. 654 // If true, the media pipeline can be suspended.
655 const bool suspend_enabled_; 655 const bool suspend_enabled_;
656 656
657 // Used for HLS playback and in certain fallback paths (e.g. on older devices 657 // Used for HLS playback and in certain fallback paths (e.g. on older devices
658 // that can't support the unified media pipeline). 658 // that can't support the unified media pipeline).
659 GURL fallback_url_; 659 GURL loaded_url_;
660 bool use_fallback_path_; 660
661 // NOTE: |using_media_player_renderer_| is set based on the usage of a
662 // MediaResource::Type::URL in StartPipeline(). This currently works because
663 // the MediaPlayerRendererClient factory is the only factory that returns that
664 // Type, but this may no longer be accurate when we remove |cast_impl_| and
665 // WebMediaPlayerCast. This flag should be renamed/updated accordingly when
666 // removing |cast_impl_|.
667 bool using_media_player_renderer_;
liberato (no reviews please) 2017/04/26 05:54:50 = false?
tguilbert 2017/04/26 18:11:53 Done.
661 668
662 // Called sometime after the media is suspended in a playing state in 669 // Called sometime after the media is suspended in a playing state in
663 // OnFrameHidden(), causing the state to change to paused. 670 // OnFrameHidden(), causing the state to change to paused.
664 base::OneShotTimer background_pause_timer_; 671 base::OneShotTimer background_pause_timer_;
665 672
666 // Monitors the watch time of the played content. 673 // Monitors the watch time of the played content.
667 std::unique_ptr<WatchTimeReporter> watch_time_reporter_; 674 std::unique_ptr<WatchTimeReporter> watch_time_reporter_;
668 bool is_encrypted_; 675 bool is_encrypted_;
669 676
670 // Elapsed time since we've last reached BUFFERING_HAVE_NOTHING. 677 // Elapsed time since we've last reached BUFFERING_HAVE_NOTHING.
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 base::CancelableCallback<void(base::TimeTicks)> frame_time_report_cb_; 731 base::CancelableCallback<void(base::TimeTicks)> frame_time_report_cb_;
725 732
726 bool initial_video_height_recorded_ = false; 733 bool initial_video_height_recorded_ = false;
727 734
728 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl); 735 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
729 }; 736 };
730 737
731 } // namespace media 738 } // namespace media
732 739
733 #endif // MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_ 740 #endif // MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
OLDNEW
« no previous file with comments | « media/base/renderer_factory_selector_unittest.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698