Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

BUG=697685
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2758683002
Cr-Commit-Position: refs/heads/master@{#459364}
Committed: https://chromium.googlesource.com/chromium/src/+/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83

[mrunal, 2017-03-17 01:16:05]

Description was changed from

==========
Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

BUG=697685
==========

to

==========
Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

BUG=697685
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[mrunal, 2017-03-17 01:18:35]

The CQ bit was checked by mrunal.kapade@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 01:19:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 02:56:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 02:56:43]

Dry run: This issue passed the CQ dry run.

[mrunal, 2017-03-17 23:22:42]

Description was changed from

==========
Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

BUG=697685
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

BUG=697685
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[mrunal, 2017-03-17 23:22:42]

mrunal.kapade@intel.com changed reviewers:
+ eae@chromium.org, tkent@chromium.org

[mrunal, 2017-03-17 23:23:24]

eae/tkent, PTAL.

[eae, 2017-03-17 23:37:45]

LGTM

https://codereview.chromium.org/2758683002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutRuby.h (right):

https://codereview.chromium.org/2758683002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutRuby.h:99: void
removeLeftoverAnonymousBlock(LayoutBlock*) override { NOTREACHED(); }
Nice :)

[eae, 2017-03-17 23:37:50]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-03-17 23:38:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 23:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 23:49:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mrunal, 2017-03-21 00:24:08]

The CQ bit was checked by mrunal.kapade@intel.com

[mrunal, 2017-03-21 00:24:09]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2758683002/#ps20001
(title: "Rebase on top of latest")

[commit-bot: I haz the power, 2017-03-21 00:24:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 02:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 02:26:37]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[mrunal, 2017-03-23 00:33:55]

The CQ bit was checked by mrunal.kapade@intel.com

[mrunal, 2017-03-23 00:33:56]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2758683002/#ps40001
(title: "Rebase with latest")

[commit-bot: I haz the power, 2017-03-23 00:35:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 01:03:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 01:03:41]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[mrunal, 2017-03-23 01:19:04]

On 2017/03/23 01:03:41, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
> (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

Looks like webkit_tests are failing with or without the patch in
linux_layout_tests_slimming_paint_v2. Should I be concerned?

[mrunal, 2017-03-24 00:54:13]

On 2017/03/23 01:19:04, mrunal wrote:
> On 2017/03/23 01:03:41, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
> > (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
> 
> Looks like webkit_tests are failing with or without the patch in
> linux_layout_tests_slimming_paint_v2. Should I be concerned?

eae, ^^^^^

[tkent, 2017-03-24 01:12:11]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-03-24 01:12:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 05:35:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490317931983000,
"parent_rev": "d62fe578e160c29f3357ac8146738f66780c7873", "commit_rev":
"1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83"}

[commit-bot: I haz the power, 2017-03-24 05:36:49]

Description was changed from

==========
Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

BUG=697685
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

BUG=697685
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2758683002
Cr-Commit-Position: refs/heads/master@{#459364}
Committed:
https://chromium.googlesource.com/chromium/src/+/1fc2d4de3e297b0ec74a5a34333c...
==========

[commit-bot: I haz the power, 2017-03-24 05:36:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1fc2d4de3e297b0ec74a5a34333c...