third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp - Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/ (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

index 53d5dfb1acd5d8d7b2625c133039496d26ee4999..d3fdb1b509a85c453182020ce65ffacb03263046 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

@@ -53,7 +53,7 @@ static const PaintLayer* findParentLayerOnClippingContainerChain(

DCHECK(!current->hasClipRelatedProperty() ||

current->styleRef().containsPaint());

}

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return nullptr;

}

@@ -64,7 +64,7 @@ static const PaintLayer* findParentLayerOnContainingBlockChain(

if (current->hasLayer())

return static_cast<const LayoutBoxModelObject*>(current)->layer();

}

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return nullptr;

}