third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp - Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp

Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/ (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp

index 42d603734bce44ba469bd901b4ddc212855b1f0b..f66fbc456bdc9b8cc562e7d5afc3c7bf55e6f5af 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp

@@ -37,7 +37,7 @@ float SVGTextMetrics::advance(FontOrientation orientation) const {

case FontOrientation::VerticalUpright:

return height();

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return width();

}