third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp - Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp

Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/ (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.	2 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.

3 *	3 *

4 * This library is free software; you can redistribute it and/or	4 * This library is free software; you can redistribute it and/or

5 * modify it under the terms of the GNU Library General Public	5 * modify it under the terms of the GNU Library General Public

6 * License as published by the Free Software Foundation; either	6 * License as published by the Free Software Foundation; either

7 * version 2 of the License, or (at your option) any later version.	7 * version 2 of the License, or (at your option) any later version.

8 *	8 *

9 * This library is distributed in the hope that it will be useful,	9 * This library is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 19 matching lines...) Expand all Loading...
30 : SVGTextMetrics(1, 0, 0) {}	30 : SVGTextMetrics(1, 0, 0) {}

31	31

32 float SVGTextMetrics::advance(FontOrientation orientation) const {	32 float SVGTextMetrics::advance(FontOrientation orientation) const {

33 switch (orientation) {	33 switch (orientation) {

34 case FontOrientation::Horizontal:	34 case FontOrientation::Horizontal:

35 case FontOrientation::VerticalRotated:	35 case FontOrientation::VerticalRotated:

36 return width();	36 return width();

37 case FontOrientation::VerticalUpright:	37 case FontOrientation::VerticalUpright:

38 return height();	38 return height();

39 default:	39 default:

40 ASSERT_NOT_REACHED();	40 NOTREACHED();

41 return width();	41 return width();

42 }	42 }

43 }	43 }

44	44

45 } // namespace blink	45 } // namespace blink

OLD	NEW