third_party/WebKit/Source/core/layout/LayoutMedia.cpp - Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMedia.cpp

Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/ (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutMedia.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutMedia.cpp b/third_party/WebKit/Source/core/layout/LayoutMedia.cpp

index f78d5102ca463b91b208262fdeef96c2fa07779f..d124303a4a5cdff4858b60a54092d174bda3bb3d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMedia.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutMedia.cpp

@@ -68,7 +68,7 @@ void LayoutMedia::layout() {

else if (child->node()->isTextTrackContainer())

seenTextTrackContainer = true;

else

- ASSERT_NOT_REACHED();

+ NOTREACHED();

#endif

// TODO(mlamouri): we miss some layouts because needsLayout returns false in