[gn] Enable stricter build flags

[gn] Enable stricter build flags

Default to the chromium-internal build config (instead of the more
permissive no_chromium_code config).

BUG=v8:5878
Review-Url: https://codereview.chromium.org/2758563002
Cr-Commit-Position: refs/heads/master@{#43909}
Committed: https://chromium.googlesource.com/v8/v8/+/542b41a7ccbcfbd6f22aa5937fbece1da613456b

[jgruber, 2017-03-16 14:17:49]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 14:17:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 14:20:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 14:20:05]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/22598)

[jgruber, 2017-03-16 15:28:06]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 15:28:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 15:31:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 15:31:03]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/24287)

[jgruber, 2017-03-17 10:19:30]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 10:19:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 10:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 10:26:28]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jgruber, 2017-03-17 10:27:39]

Description was changed from

==========
Stricter GN build flags
==========

to

==========
[gn] Enable stricter build flags

Ever had a CL fail CQ because of an unused variable on the windows
bot (resulting in another edit/upload/cq cycle)?

This CL fixes that by defaulting to the chromium-internal build
config (instead of the more permissive no_chromium_code config).
==========

[jgruber, 2017-03-17 10:37:04]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 10:37:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 10:39:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 10:39:59]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/24359)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[jgruber, 2017-03-17 10:45:02]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 10:45:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 10:47:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 10:48:00]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/24453)

[jgruber, 2017-03-17 10:49:50]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 10:49:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 10:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 10:53:29]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/24363)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/24454)

[jgruber, 2017-03-17 11:17:33]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 11:17:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 11:20:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 11:20:54]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/24368)

[jgruber, 2017-03-17 11:35:12]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 11:35:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 11:36:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 11:36:53]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/19267)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/36977)

[jgruber, 2017-03-17 11:44:47]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 11:44:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-17 11:47:25]

Description was changed from

==========
[gn] Enable stricter build flags

Ever had a CL fail CQ because of an unused variable on the windows
bot (resulting in another edit/upload/cq cycle)?

This CL fixes that by defaulting to the chromium-internal build
config (instead of the more permissive no_chromium_code config).
==========

to

==========
[gn] Enable stricter build flags

Ever had a CL fail CQ because of an unused variable on the windows
bot (resulting in another edit/upload/cq cycle)?

This CL fixes that by defaulting to the chromium-internal build
config (instead of the more permissive no_chromium_code config).

BUG=v8:5878
==========

[commit-bot: I haz the power, 2017-03-17 11:50:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 11:50:23]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[jgruber, 2017-03-17 11:56:21]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 11:56:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 12:00:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 12:00:24]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[jgruber, 2017-03-17 12:12:04]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 12:12:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 12:16:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 12:16:25]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[jgruber, 2017-03-17 12:35:08]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 12:35:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 12:41:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 12:41:50]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[jgruber, 2017-03-17 12:48:43]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 12:48:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 12:53:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 12:53:29]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[jgruber, 2017-03-17 13:01:27]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 13:01:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-17 13:03:09]

Description was changed from

==========
[gn] Enable stricter build flags

Ever had a CL fail CQ because of an unused variable on the windows
bot (resulting in another edit/upload/cq cycle)?

This CL fixes that by defaulting to the chromium-internal build
config (instead of the more permissive no_chromium_code config).

BUG=v8:5878
==========

to

==========
[gn] Enable stricter build flags

Default to the chromium-internal build config (instead of the more
permissive no_chromium_code config).

BUG=v8:5878
==========

[commit-bot: I haz the power, 2017-03-17 13:08:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 13:08:19]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jgruber, 2017-03-17 13:12:21]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 13:12:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-17 13:21:19]

jgruber@chromium.org changed reviewers:
+ ahaas@chromium.org, jochen@chromium.org, machenbach@chromium.org,
mstarzinger@chromium.org

[jgruber, 2017-03-17 13:21:20]

Hi folks, please take a look. This CL makes gn default to stricter build flags
(e.g. it should finally complain about unused variables locally).

The build system changes are in BUILD.gn and gni/v8.gni, and the remaining
changes are fixes for compile warnings.

https://codereview.chromium.org/2758563002/diff/260001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2758563002/diff/260001/BUILD.gn#newcode468
BUILD.gn:468: cflags += [
4267, 4245: Pedantic conversion warnings. We might want to fix these, but this
would be another mismatch between windows bot builds and local builds.
4324: This seems like an FYI, nothing wrong with this pattern.
4701, 4703: Some false positives, and all over our code. May want to fix this.
4702: Can't handle our UNREACHABLE() macro.
4709: Windows compiler bug.
4718: Seems like FYI.
4800: Pedantic warning that triggers e.g. on static_cast<bool>(int).

https://codereview.chromium.org/2758563002/diff/260001/src/profiler/heap-snap...
File src/profiler/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/2758563002/diff/260001/src/profiler/heap-snap...
src/profiler/heap-snapshot-generator.cc:1718: USE(builtins);
Not sure what's up with this, produces an initialized but unused warning. Maybe
a compiler bug?

[jochen (gone - plz use gerrit), 2017-03-17 13:25:39]

lgtm

[commit-bot: I haz the power, 2017-03-17 13:32:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 13:32:14]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2017-03-17 13:36:02]

lgtm, awesome job!

[Michael Achenbach, 2017-03-17 13:36:36]

Not, this might run into more things on the bots we don't have in CQ, but lets
wait and see...

[Michael Achenbach, 2017-03-17 13:36:48]

*Note

[Hannes Payer (out of office), 2017-03-17 13:39:17]

On 2017/03/17 13:36:48, Michael Achenbach wrote:
> *Note

heap lgtm

[ahaas, 2017-03-17 14:18:22]

On 2017/03/17 at 13:39:17, hpayer wrote:
> On 2017/03/17 13:36:48, Michael Achenbach wrote:
> > *Note
> 
> heap lgtm

wasm lgtm

[Michael Starzinger, 2017-03-17 14:38:09]

LGTM on "compiler".

https://codereview.chromium.org/2758563002/diff/280001/src/compiler/gap-resol...
File src/compiler/gap-resolver.cc (right):

https://codereview.chromium.org/2758563002/diff/280001/src/compiler/gap-resol...
src/compiler/gap-resolver.cc:216: if (!kSimpleFPAliasing && is_fp_loc_move) {
Isn't this predicate also affected?

[jgruber, 2017-03-17 14:49:56]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 14:50:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-17 15:15:47]

The CQ bit was unchecked by jgruber@chromium.org

[jgruber, 2017-03-17 15:15:53]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-03-17 15:15:54]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
jochen@chromium.org, ahaas@chromium.org, mstarzinger@chromium.org,
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2758563002/#ps290001
(title: "Address comment")

[commit-bot: I haz the power, 2017-03-17 15:16:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-17 15:16:09]

https://codereview.chromium.org/2758563002/diff/280001/src/compiler/gap-resol...
File src/compiler/gap-resolver.cc (right):

https://codereview.chromium.org/2758563002/diff/280001/src/compiler/gap-resol...
src/compiler/gap-resolver.cc:216: if (!kSimpleFPAliasing && is_fp_loc_move) {
On 2017/03/17 14:38:09, Michael Starzinger wrote:
> Isn't this predicate also affected?

Done.

[commit-bot: I haz the power, 2017-03-17 15:18:20]

CQ is committing da patch.

Bot data: {"patchset_id": 290001, "attempt_start_ts": 1489763753701270,
"parent_rev": "1191e6f6ef03df5775fd881223fe32499d3eb199", "commit_rev":
"542b41a7ccbcfbd6f22aa5937fbece1da613456b"}

[commit-bot: I haz the power, 2017-03-17 15:18:29]

Description was changed from

==========
[gn] Enable stricter build flags

Default to the chromium-internal build config (instead of the more
permissive no_chromium_code config).

BUG=v8:5878
==========

to

==========
[gn] Enable stricter build flags

Default to the chromium-internal build config (instead of the more
permissive no_chromium_code config).

BUG=v8:5878

Review-Url: https://codereview.chromium.org/2758563002
Cr-Commit-Position: refs/heads/master@{#43909}
Committed:
https://chromium.googlesource.com/v8/v8/+/542b41a7ccbcfbd6f22aa5937fbece1da61...
==========

[commit-bot: I haz the power, 2017-03-17 15:18:31]

Committed patchset #16 (id:290001) as
https://chromium.googlesource.com/v8/v8/+/542b41a7ccbcfbd6f22aa5937fbece1da61...