Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: src/api.cc

Issue 2758563002: [gn] Enable stricter build flags (Closed)
Patch Set: Address comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gni/v8.gni ('k') | src/ast/context-slot-cache.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/api.h" 5 #include "src/api.h"
6 6
7 #include <string.h> // For memcpy, strlen. 7 #include <string.h> // For memcpy, strlen.
8 #ifdef V8_USE_ADDRESS_SANITIZER 8 #ifdef V8_USE_ADDRESS_SANITIZER
9 #include <sanitizer/asan_interface.h> 9 #include <sanitizer/asan_interface.h>
10 #endif // V8_USE_ADDRESS_SANITIZER 10 #endif // V8_USE_ADDRESS_SANITIZER
(...skipping 9387 matching lines...) Expand 10 before | Expand all | Expand 10 after
9398 PersistentValueVector<debug::Script>& scripts) { 9398 PersistentValueVector<debug::Script>& scripts) {
9399 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate); 9399 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
9400 ENTER_V8(isolate); 9400 ENTER_V8(isolate);
9401 // TODO(kozyatinskiy): remove this GC once tests are dealt with. 9401 // TODO(kozyatinskiy): remove this GC once tests are dealt with.
9402 isolate->heap()->CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask, 9402 isolate->heap()->CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask,
9403 i::GarbageCollectionReason::kDebugger); 9403 i::GarbageCollectionReason::kDebugger);
9404 { 9404 {
9405 i::DisallowHeapAllocation no_gc; 9405 i::DisallowHeapAllocation no_gc;
9406 i::Script::Iterator iterator(isolate); 9406 i::Script::Iterator iterator(isolate);
9407 i::Script* script; 9407 i::Script* script;
9408 while ((script = iterator.Next())) { 9408 while ((script = iterator.Next()) != nullptr) {
9409 if (!script->IsUserJavaScript()) continue; 9409 if (!script->IsUserJavaScript()) continue;
9410 if (script->HasValidSource()) { 9410 if (script->HasValidSource()) {
9411 i::HandleScope handle_scope(isolate); 9411 i::HandleScope handle_scope(isolate);
9412 i::Handle<i::Script> script_handle(script, isolate); 9412 i::Handle<i::Script> script_handle(script, isolate);
9413 scripts.Append(ToApiHandle<Script>(script_handle)); 9413 scripts.Append(ToApiHandle<Script>(script_handle));
9414 } 9414 }
9415 } 9415 }
9416 } 9416 }
9417 } 9417 }
9418 9418
(...skipping 834 matching lines...) Expand 10 before | Expand all | Expand 10 after
10253 Address callback_address = 10253 Address callback_address =
10254 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback)); 10254 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
10255 VMState<EXTERNAL> state(isolate); 10255 VMState<EXTERNAL> state(isolate);
10256 ExternalCallbackScope call_scope(isolate, callback_address); 10256 ExternalCallbackScope call_scope(isolate, callback_address);
10257 callback(info); 10257 callback(info);
10258 } 10258 }
10259 10259
10260 10260
10261 } // namespace internal 10261 } // namespace internal
10262 } // namespace v8 10262 } // namespace v8
OLDNEW
« no previous file with comments | « gni/v8.gni ('k') | src/ast/context-slot-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698