Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: src/heap/heap.cc

Issue 2758563002: [gn] Enable stricter build flags (Closed)
Patch Set: Address comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/heap.h ('k') | src/heap/heap-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/heap.h" 5 #include "src/heap/heap.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/assembler-inl.h" 9 #include "src/assembler-inl.h"
10 #include "src/ast/context-slot-cache.h" 10 #include "src/ast/context-slot-cache.h"
(...skipping 740 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 { 751 {
752 TRACE_GC(tracer(), GCTracer::Scope::HEAP_EPILOGUE_REDUCE_NEW_SPACE); 752 TRACE_GC(tracer(), GCTracer::Scope::HEAP_EPILOGUE_REDUCE_NEW_SPACE);
753 ReduceNewSpaceSize(); 753 ReduceNewSpaceSize();
754 } 754 }
755 } 755 }
756 756
757 757
758 void Heap::PreprocessStackTraces() { 758 void Heap::PreprocessStackTraces() {
759 WeakFixedArray::Iterator iterator(weak_stack_trace_list()); 759 WeakFixedArray::Iterator iterator(weak_stack_trace_list());
760 FixedArray* elements; 760 FixedArray* elements;
761 while ((elements = iterator.Next<FixedArray>())) { 761 while ((elements = iterator.Next<FixedArray>()) != nullptr) {
762 for (int j = 1; j < elements->length(); j += 4) { 762 for (int j = 1; j < elements->length(); j += 4) {
763 Object* maybe_code = elements->get(j + 2); 763 Object* maybe_code = elements->get(j + 2);
764 // If GC happens while adding a stack trace to the weak fixed array, 764 // If GC happens while adding a stack trace to the weak fixed array,
765 // which has been copied into a larger backing store, we may run into 765 // which has been copied into a larger backing store, we may run into
766 // a stack trace that has already been preprocessed. Guard against this. 766 // a stack trace that has already been preprocessed. Guard against this.
767 if (!maybe_code->IsAbstractCode()) break; 767 if (!maybe_code->IsAbstractCode()) break;
768 AbstractCode* abstract_code = AbstractCode::cast(maybe_code); 768 AbstractCode* abstract_code = AbstractCode::cast(maybe_code);
769 int offset = Smi::cast(elements->get(j + 3))->value(); 769 int offset = Smi::cast(elements->get(j + 3))->value();
770 int pos = abstract_code->SourcePosition(offset); 770 int pos = abstract_code->SourcePosition(offset);
771 elements->set(j + 2, Smi::FromInt(pos)); 771 elements->set(j + 2, Smi::FromInt(pos));
(...skipping 5599 matching lines...) Expand 10 before | Expand all | Expand 10 after
6371 } 6371 }
6372 6372
6373 6373
6374 // static 6374 // static
6375 int Heap::GetStaticVisitorIdForMap(Map* map) { 6375 int Heap::GetStaticVisitorIdForMap(Map* map) {
6376 return StaticVisitorBase::GetVisitorId(map); 6376 return StaticVisitorBase::GetVisitorId(map);
6377 } 6377 }
6378 6378
6379 } // namespace internal 6379 } // namespace internal
6380 } // namespace v8 6380 } // namespace v8
OLDNEW
« no previous file with comments | « src/heap/heap.h ('k') | src/heap/heap-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698