Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: BUILD.gn

Issue 2758563002: [gn] Enable stricter build flags (Closed)
Patch Set: Address comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gni/v8.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 568ab50f344e1dcf152df61dcb5a29f0e11f1e9c..f6499e716e3a5448d501803998d717d6ccccf6b8 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -463,6 +463,20 @@ config("toolchain") {
# cflags += [ "-Wshorten-64-to-32" ]
#}
}
+
+ if (is_win) {
+ cflags += [
+ "/wd4245", # Conversion with signed/unsigned mismatch.
+ "/wd4267", # Conversion with possible loss of data.
+ "/wd4324", # Padding structure due to alignment.
+ "/wd4701", # Potentially uninitialized local variable.
+ "/wd4702", # Unreachable code.
+ "/wd4703", # Potentially uninitialized local pointer variable.
+ "/wd4709", # Comma operator within array index expr (bugged).
+ "/wd4718", # Recursive call has no side-effect.
+ "/wd4800", # Forcing value to bool.
+ ]
+ }
}
###############################################################################
@@ -2289,11 +2303,6 @@ v8_source_set("v8_base") {
sources += [ v8_generated_peephole_source ]
deps += [ ":run_mkpeephole" ]
- if (is_win) {
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- cflags = [ "/wd4267" ]
- }
-
if (v8_enable_i18n_support) {
deps += [ "//third_party/icu" ]
if (is_win) {
« no previous file with comments | « no previous file | gni/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698