Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: BUILD.gn

Issue 2758563002: [gn] Enable stricter build flags (Closed)
Patch Set: Address comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gni/v8.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/arm.gni") 6 import("//build/config/arm.gni")
7 import("//build/config/dcheck_always_on.gni") 7 import("//build/config/dcheck_always_on.gni")
8 import("//build/config/mips.gni") 8 import("//build/config/mips.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 10
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 "-Wsign-compare", 456 "-Wsign-compare",
457 457
458 # TODO(hans): Remove once http://crbug.com/428099 is resolved. 458 # TODO(hans): Remove once http://crbug.com/428099 is resolved.
459 "-Winconsistent-missing-override", 459 "-Winconsistent-missing-override",
460 ] 460 ]
461 #if (v8_current_cpu == "x64" || v8_current_cpu == "arm64" || 461 #if (v8_current_cpu == "x64" || v8_current_cpu == "arm64" ||
462 # v8_current_cpu == "mips64el") { 462 # v8_current_cpu == "mips64el") {
463 # cflags += [ "-Wshorten-64-to-32" ] 463 # cflags += [ "-Wshorten-64-to-32" ]
464 #} 464 #}
465 } 465 }
466
467 if (is_win) {
468 cflags += [
469 "/wd4245", # Conversion with signed/unsigned mismatch.
470 "/wd4267", # Conversion with possible loss of data.
471 "/wd4324", # Padding structure due to alignment.
472 "/wd4701", # Potentially uninitialized local variable.
473 "/wd4702", # Unreachable code.
474 "/wd4703", # Potentially uninitialized local pointer variable.
475 "/wd4709", # Comma operator within array index expr (bugged).
476 "/wd4718", # Recursive call has no side-effect.
477 "/wd4800", # Forcing value to bool.
478 ]
479 }
466 } 480 }
467 481
468 ############################################################################### 482 ###############################################################################
469 # Actions 483 # Actions
470 # 484 #
471 485
472 action("js2c") { 486 action("js2c") {
473 visibility = [ ":*" ] # Only targets in this file can depend on this. 487 visibility = [ ":*" ] # Only targets in this file can depend on this.
474 488
475 script = "tools/js2c.py" 489 script = "tools/js2c.py"
(...skipping 1806 matching lines...) Expand 10 before | Expand all | Expand 10 after
2282 defines = [] 2296 defines = []
2283 deps = [ 2297 deps = [
2284 ":v8_libbase", 2298 ":v8_libbase",
2285 ":v8_libsampler", 2299 ":v8_libsampler",
2286 ":v8_version", 2300 ":v8_version",
2287 ] 2301 ]
2288 2302
2289 sources += [ v8_generated_peephole_source ] 2303 sources += [ v8_generated_peephole_source ]
2290 deps += [ ":run_mkpeephole" ] 2304 deps += [ ":run_mkpeephole" ]
2291 2305
2292 if (is_win) {
2293 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
2294 cflags = [ "/wd4267" ]
2295 }
2296
2297 if (v8_enable_i18n_support) { 2306 if (v8_enable_i18n_support) {
2298 deps += [ "//third_party/icu" ] 2307 deps += [ "//third_party/icu" ]
2299 if (is_win) { 2308 if (is_win) {
2300 deps += [ "//third_party/icu:icudata" ] 2309 deps += [ "//third_party/icu:icudata" ]
2301 } 2310 }
2302 } else { 2311 } else {
2303 sources -= [ 2312 sources -= [
2304 "src/i18n.cc", 2313 "src/i18n.cc",
2305 "src/i18n.h", 2314 "src/i18n.h",
2306 ] 2315 ]
(...skipping 868 matching lines...) Expand 10 before | Expand all | Expand 10 after
3175 ] 3184 ]
3176 3185
3177 configs = [ 3186 configs = [
3178 ":external_config", 3187 ":external_config",
3179 ":internal_config_base", 3188 ":internal_config_base",
3180 ] 3189 ]
3181 } 3190 }
3182 3191
3183 v8_fuzzer("wasm_compile_fuzzer") { 3192 v8_fuzzer("wasm_compile_fuzzer") {
3184 } 3193 }
OLDNEW
« no previous file with comments | « no previous file | gni/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698