Cleanup anonymous text objects that pass the document as a node.

Cleanup anonymous text objects that pass the document as a node.

This CL requires a pseudo-element to own the anonymous layout object in most of
cases. This doesn't switch yet to having the pseudo in LayoutObject::m_node.

This is preliminar work for display: contents pseudos.

BUG=657748
Review-Url: https://codereview.chromium.org/2754653002
Cr-Commit-Position: refs/heads/master@{#457121}
Committed: https://chromium.googlesource.com/chromium/src/+/b4f78964d73c1f967ce5d3e8ca914dcc41eec1e7

[emilio, 2017-03-15 10:39:20]

The CQ bit was checked by ecobos@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 10:39:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 12:20:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 12:20:51]

Dry run: This issue passed the CQ dry run.

[emilio, 2017-03-15 12:30:19]

ecobos@igalia.com changed reviewers:
+ rune@opera.com

[emilio, 2017-03-15 12:30:20]

Hi rune,

This is split from my display: contents pseudo-elements CL, could you take a
look?

Thanks in advance! :)

[rune, 2017-03-15 14:58:37]

lgtm with nits.

https://codereview.chromium.org/2754653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp (right):

https://codereview.chromium.org/2754653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp:55: StringImpl*
str,
I think "text" is a better name than "str" here.

https://codereview.chromium.org/2754653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ContentData.cpp (right):

https://codereview.chromium.org/2754653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ContentData.cpp:25: #include <memory>
I thought we used to include them below. Did the upload check complain about
this?

[emilio, 2017-03-15 15:36:15]

https://codereview.chromium.org/2754653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp (right):

https://codereview.chromium.org/2754653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp:55: StringImpl*
str,
On 2017/03/15 14:58:37, rune wrote:
> I think "text" is a better name than "str" here.

Agreed, done.

https://codereview.chromium.org/2754653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ContentData.cpp (right):

https://codereview.chromium.org/2754653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ContentData.cpp:25: #include <memory>
On 2017/03/15 14:58:37, rune wrote:
> I thought we used to include them below. Did the upload check complain about
> this?

Yes, git cl format did this change, and reverting it manually makes the
presubmit check warn.

[emilio, 2017-03-15 15:36:24]

The CQ bit was checked by ecobos@igalia.com

[emilio, 2017-03-15 15:36:24]

The patchset sent to the CQ was uploaded after l-g-t-m from rune@opera.com
Link to the patchset: https://codereview.chromium.org/2754653002/#ps20001
(title: "Cleanup anonymous text objects that pass the document as a node.")

[commit-bot: I haz the power, 2017-03-15 15:36:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 17:31:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489592184084600,
"parent_rev": "23bc6ad928303b4130db974befd578461ea7b02f", "commit_rev":
"b4f78964d73c1f967ce5d3e8ca914dcc41eec1e7"}

[commit-bot: I haz the power, 2017-03-15 17:43:37]

Description was changed from

==========
Cleanup anonymous text objects that pass the document as a node.

This CL requires a pseudo-element to own the anonymous layout object in most of
cases. This doesn't switch yet to having the pseudo in LayoutObject::m_node.

This is preliminar work for display: contents pseudos.

BUG=657748
==========

to

==========
Cleanup anonymous text objects that pass the document as a node.

This CL requires a pseudo-element to own the anonymous layout object in most of
cases. This doesn't switch yet to having the pseudo in LayoutObject::m_node.

This is preliminar work for display: contents pseudos.

BUG=657748

Review-Url: https://codereview.chromium.org/2754653002
Cr-Commit-Position: refs/heads/master@{#457121}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4f78964d73c1f967ce5d3e8ca91...
==========

[commit-bot: I haz the power, 2017-03-15 17:43:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b4f78964d73c1f967ce5d3e8ca91...