third_party/WebKit/Source/core/layout/LayoutMenuList.cpp - Issue 2754653002: Cleanup anonymous text objects that pass the document as a node.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

Issue 2754653002: Cleanup anonymous text objects that pass the document as a node. (Closed)

Patch Set: Cleanup anonymous text objects that pass the document as a node. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp b/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

index d62d3e45a523ee365d1da7eee02c88f4cff28cc6..a9353af77d91f01d4fd82b4fd2e0237a229a54ee 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

@@ -70,7 +70,7 @@ void LayoutMenuList::createInnerBlock() {

ASSERT(!firstChild());

m_innerBlock = createAnonymousBlock();

- m_buttonText = new LayoutText(&document(), StringImpl::empty);

+ m_buttonText = LayoutText::createEmptyAnonymous(document());

// We need to set the text explicitly though it was specified in the

// constructor because LayoutText doesn't refer to the text

// specified in the constructor in a case of re-transforming.