Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutQuote.h

Issue 2754653002: Cleanup anonymous text objects that pass the document as a node. (Closed)
Patch Set: Cleanup anonymous text objects that pass the document as a node. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutQuote.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutQuote.h b/third_party/WebKit/Source/core/layout/LayoutQuote.h
index 3b460372d2511f59858c4d495865caa4dcaa1350..96c633bbf3bb07759f4fd5c7a4dd115f4c05454f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutQuote.h
+++ b/third_party/WebKit/Source/core/layout/LayoutQuote.h
@@ -27,8 +27,8 @@
namespace blink {
-class Document;
class LayoutTextFragment;
+class PseudoElement;
// LayoutQuote is the layout object associated with generated quotes
// ("content: open-quote | close-quote | no-open-quote | no-close-quote").
@@ -40,7 +40,7 @@ class LayoutTextFragment;
// and |m_previous| below.
class LayoutQuote final : public LayoutInline {
public:
- LayoutQuote(Document*, const QuoteType);
+ LayoutQuote(PseudoElement&, const QuoteType);
~LayoutQuote() override;
void attachQuote();
@@ -81,6 +81,11 @@ class LayoutQuote final : public LayoutInline {
LayoutQuote* m_next;
LayoutQuote* m_previous;
+ // The pseudo-element that owns us.
+ //
+ // Lifetime is the same as LayoutObject::m_node, so this is safe.
+ UntracedMember<PseudoElement> m_owningPseudo;
+
// This tracks whether this LayoutQuote was inserted into the layout tree
// and its position in the linked list is correct (m_next and m_previous).
// It's used for both performance (avoid unneeded tree walks to find the
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMenuList.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutQuote.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698