Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: third_party/WebKit/Source/core/style/ContentData.h

Issue 2754653002: Cleanup anonymous text objects that pass the document as a node. (Closed)
Patch Set: Cleanup anonymous text objects that pass the document as a node. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ContentData.h
diff --git a/third_party/WebKit/Source/core/style/ContentData.h b/third_party/WebKit/Source/core/style/ContentData.h
index 0b25bccf652d5057debb93c9494df3c5626ec509..de0d47cd65ddf403f876eafd60bf7ad278f279bf 100644
--- a/third_party/WebKit/Source/core/style/ContentData.h
+++ b/third_party/WebKit/Source/core/style/ContentData.h
@@ -33,9 +33,9 @@
namespace blink {
-class Document;
-class LayoutObject;
class ComputedStyle;
+class LayoutObject;
+class PseudoElement;
class ContentData : public GarbageCollectedFinalized<ContentData> {
public:
@@ -51,7 +51,8 @@ class ContentData : public GarbageCollectedFinalized<ContentData> {
virtual bool isQuote() const { return false; }
virtual bool isText() const { return false; }
- virtual LayoutObject* createLayoutObject(Document&, ComputedStyle&) const = 0;
+ virtual LayoutObject* createLayoutObject(PseudoElement&,
+ ComputedStyle&) const = 0;
virtual ContentData* clone() const;
@@ -84,7 +85,8 @@ class ImageContentData final : public ContentData {
}
bool isImage() const override { return true; }
- LayoutObject* createLayoutObject(Document&, ComputedStyle&) const override;
+ LayoutObject* createLayoutObject(PseudoElement&,
+ ComputedStyle&) const override;
bool equals(const ContentData& data) const override {
if (!data.isImage())
@@ -115,7 +117,8 @@ class TextContentData final : public ContentData {
void setText(const String& text) { m_text = text; }
bool isText() const override { return true; }
- LayoutObject* createLayoutObject(Document&, ComputedStyle&) const override;
+ LayoutObject* createLayoutObject(PseudoElement&,
+ ComputedStyle&) const override;
bool equals(const ContentData& data) const override {
if (!data.isText())
@@ -143,7 +146,8 @@ class CounterContentData final : public ContentData {
}
bool isCounter() const override { return true; }
- LayoutObject* createLayoutObject(Document&, ComputedStyle&) const override;
+ LayoutObject* createLayoutObject(PseudoElement&,
+ ComputedStyle&) const override;
private:
CounterContentData(std::unique_ptr<CounterContent> counter)
@@ -175,7 +179,8 @@ class QuoteContentData final : public ContentData {
void setQuote(QuoteType quote) { m_quote = quote; }
bool isQuote() const override { return true; }
- LayoutObject* createLayoutObject(Document&, ComputedStyle&) const override;
+ LayoutObject* createLayoutObject(PseudoElement&,
+ ComputedStyle&) const override;
bool equals(const ContentData& data) const override {
if (!data.isQuote())
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp ('k') | third_party/WebKit/Source/core/style/ContentData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698