Cleanup anonymous text objects that pass the document as a node.

third_party/WebKit/Source/core/style/ContentData.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #include "core/style/ContentData.h"
 
+#include <memory>

[rune, 2017/03/15 14:58:37]

I thought we used to include them below. Did the upload check complain about
this?

[emilio, 2017/03/15 15:36:15]

Yes, git cl format did this change, and reverting it manually makes the
presubmit check warn.

+#include "core/dom/PseudoElement.h"
 #include "core/layout/LayoutCounter.h"
 #include "core/layout/LayoutImage.h"
 #include "core/layout/LayoutImageResource.h"
 #include "core/layout/LayoutImageResourceStyleImage.h"
 #include "core/layout/LayoutQuote.h"
 #include "core/layout/LayoutTextFragment.h"
 #include "core/style/ComputedStyle.h"
-#include <memory>
 
 namespace blink {
 
 ContentData* ContentData::create(StyleImage* image) {
   return new ImageContentData(image);
 }
 
 ContentData* ContentData::create(const String& text) {
   return new TextContentData(text);
 }
@@ skipping 18 matching lines @@
   }
 
   return result;
 }
 
 DEFINE_TRACE(ContentData) {
   visitor->trace(m_next);
 }
 
 LayoutObject* ImageContentData::createLayoutObject(
-    Document& doc,
+    PseudoElement& pseudo,
     ComputedStyle& pseudoStyle) const {
-  LayoutImage* image = LayoutImage::createAnonymous(&doc);
+  LayoutImage* image = LayoutImage::createAnonymous(pseudo);
   image->setPseudoStyle(&pseudoStyle);
   if (m_image)
     image->setImageResource(
         LayoutImageResourceStyleImage::create(m_image.get()));
   else
     image->setImageResource(LayoutImageResource::create());
   return image;
 }
 
 DEFINE_TRACE(ImageContentData) {
   visitor->trace(m_image);
   ContentData::trace(visitor);
 }
 
 LayoutObject* TextContentData::createLayoutObject(
-    Document& doc,
+    PseudoElement& pseudo,
     ComputedStyle& pseudoStyle) const {
-  LayoutObject* layoutObject = new LayoutTextFragment(&doc, m_text.impl());
+  LayoutObject* layoutObject =
+      LayoutTextFragment::createAnonymous(pseudo, m_text.impl());
   layoutObject->setPseudoStyle(&pseudoStyle);
   return layoutObject;
 }
 
 LayoutObject* CounterContentData::createLayoutObject(
-    Document& doc,
+    PseudoElement& pseudo,
     ComputedStyle& pseudoStyle) const {
-  LayoutObject* layoutObject = new LayoutCounter(&doc, *m_counter);
+  LayoutObject* layoutObject = new LayoutCounter(pseudo, *m_counter);
   layoutObject->setPseudoStyle(&pseudoStyle);
   return layoutObject;
 }
 
 LayoutObject* QuoteContentData::createLayoutObject(
-    Document& doc,
+    PseudoElement& pseudo,
     ComputedStyle& pseudoStyle) const {
-  LayoutObject* layoutObject = new LayoutQuote(&doc, m_quote);
+  LayoutObject* layoutObject = new LayoutQuote(pseudo, m_quote);
   layoutObject->setPseudoStyle(&pseudoStyle);
   return layoutObject;
 }
 
 }  // namespace blink