Non-const impls. for WebMediaPlayer::didLoadingProgress().

Non-const impls. for WebMediaPlayer::didLoadingProgress().

This provides non-const didLoadingProgress() implementations for WebMediaPlayer subclasses in Chromium so that the interface can switch to being non-const. It also removes the const specifier from DidLoadingProgress() implementations (Pipeline and DemuxerHost) and the mutable specifier for their associated properties.

This is the first of three changes; the second is
https://codereview.chromium.org/272223004.

BUG=360251
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269910

[sandersd (OOO until July 31), 2014-05-09 22:14:43]

Depending how you feel about temporarily duplicated code, this should be an easy
one.

[sandersd (OOO until July 31), 2014-05-09 22:28:23]

(Actually add a reviewer)

[scherkus (not reviewing), 2014-05-09 22:39:17]

https://codereview.chromium.org/275303002/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.h (right):

https://codereview.chromium.org/275303002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.h:337: mutable bool
did_loading_progress_;
I think we can have this CL remove all the mutable stuff here + in Pipeline

then we can stick a const_cast<T*>(this)->didLoadingProgress() in the const
version of the method

[scherkus (not reviewing), 2014-05-09 22:40:20]

https://codereview.chromium.org/275303002/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.h (right):

https://codereview.chromium.org/275303002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.h:337: mutable bool
did_loading_progress_;
On 2014/05/09 22:39:18, scherkus wrote:
> I think we can have this CL remove all the mutable stuff here + in Pipeline
> 
> then we can stick a const_cast<T*>(this)->didLoadingProgress() in the const
> version of the method

(doing it this way accomplishes the real goal of getting rid of "mutable"
everywhere and also isolates the grossness into the smallest possible spot: the
const versions of didLoadingProgress())

[sandersd (OOO until July 31), 2014-05-09 23:05:56]

https://codereview.chromium.org/275303002/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.h (right):

https://codereview.chromium.org/275303002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.h:337: mutable bool
did_loading_progress_;
On 2014/05/09 22:40:21, scherkus wrote:
> On 2014/05/09 22:39:18, scherkus wrote:
> > I think we can have this CL remove all the mutable stuff here + in Pipeline
> > 
> > then we can stick a const_cast<T*>(this)->didLoadingProgress() in the const
> > version of the method
> 
> (doing it this way accomplishes the real goal of getting rid of "mutable"
> everywhere and also isolates the grossness into the smallest possible spot:
the
> const versions of didLoadingProgress())

Sure, I had that planned for the third CL, but I suppose there is no reason not
to do it right now.

[scherkus (not reviewing), 2014-05-09 23:08:37]

don't forget to update the CL description to encompass the mutable changes


other than that lgtm! thanks for the cleanup!

[sandersd (OOO until July 31), 2014-05-09 23:16:31]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-05-09 23:18:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sandersd@chromium.org/275303002/20001

[commit-bot: I haz the power, 2014-05-10 02:52:11]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-10 04:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-10 04:21:45]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[sandersd (OOO until July 31), 2014-05-12 22:11:27]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-05-12 22:12:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sandersd@chromium.org/275303002/20001

[commit-bot: I haz the power, 2014-05-12 23:27:32]

Change committed as 269910