content/renderer/media/buffered_data_source_host_impl.h - Issue 275303002: Non-const impls. for WebMediaPlayer::didLoadingProgress().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/buffered_data_source_host_impl.h

Issue 275303002: Non-const impls. for WebMediaPlayer::didLoadingProgress(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove mutable bools. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/android/webmediaplayer_android.cc ('k') | content/renderer/media/buffered_data_source_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/buffered_data_source_host_impl.h

diff --git a/content/renderer/media/buffered_data_source_host_impl.h b/content/renderer/media/buffered_data_source_host_impl.h

index 788050fb75f91b87155b759575dc84f7bf7f4e69..301b08ea966b41dba852e2d675d6e90b35622497 100644

--- a/content/renderer/media/buffered_data_source_host_impl.h

+++ b/content/renderer/media/buffered_data_source_host_impl.h

@@ -29,9 +29,7 @@ class CONTENT_EXPORT BufferedDataSourceHostImpl

media::Ranges<base::TimeDelta>* buffered_time_ranges,

base::TimeDelta media_duration);

- // TODO(sandersd): Change this to non-const along with Pipeline's version.

- // http://crbug.com/360251

- bool DidLoadingProgress() const;

+ bool DidLoadingProgress();

private:

// Total size of the data source.

@@ -42,7 +40,7 @@ class CONTENT_EXPORT BufferedDataSourceHostImpl

// True when AddBufferedByteRange() has been called more recently than

// DidLoadingProgress().

- mutable bool did_loading_progress_;

+ bool did_loading_progress_;

DISALLOW_COPY_AND_ASSIGN(BufferedDataSourceHostImpl);

};