media/base/pipeline.h - Issue 275303002: Non-const impls. for WebMediaPlayer::didLoadingProgress().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/pipeline.h

Issue 275303002: Non-const impls. for WebMediaPlayer::didLoadingProgress(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove mutable bools. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/pipeline.h

diff --git a/media/base/pipeline.h b/media/base/pipeline.h

index c4de1ce1a346c1d22a38ebf42c6f5305bdd51b0a..f0d34b351c8dbc0f6aa8c1f54ec5f709cced469d 100644

--- a/media/base/pipeline.h

+++ b/media/base/pipeline.h

@@ -172,7 +172,7 @@ class MEDIA_EXPORT Pipeline : public DemuxerHost {

// Return true if loading progress has been made since the last time this

// method was called.

- bool DidLoadingProgress() const;

+ bool DidLoadingProgress();

// Gets the current pipeline statistics.

PipelineStatistics GetStatistics() const;

@@ -335,7 +335,7 @@ class MEDIA_EXPORT Pipeline : public DemuxerHost {

// True when AddBufferedTimeRange() has been called more recently than

// DidLoadingProgress().

- mutable bool did_loading_progress_;

+ bool did_loading_progress_;

// Current volume level (from 0.0f to 1.0f). This value is set immediately

// via SetVolume() and a task is dispatched on the task runner to notify the

« no previous file with comments | « content/renderer/media/webmediaplayer_ms.cc ('k') | media/base/pipeline.cc » ('j') | no next file with comments »