Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 272223004: Make WebMediaPlayer::didLoadingProgress() non-const. (Closed)

Created:
6 years, 7 months ago by sandersd (OOO until July 31)
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, philipj_slow, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make WebMediaPlayer::didLoadingProgress() non-const. The Chromium-side change is https://codereview.chromium.org/275303002, which must be committed first. BUG=360251 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M public/platform/WebMediaPlayer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sandersd (OOO until July 31)
6 years, 7 months ago (2014-05-09 22:16:35 UTC) #1
sandersd (OOO until July 31)
(Actually add as a reviewer)
6 years, 7 months ago (2014-05-09 22:29:03 UTC) #2
sandersd (OOO until July 31)
Pick a reviewer not OOO.
6 years, 7 months ago (2014-05-12 23:48:28 UTC) #3
darin (slow to review)
LGTM
6 years, 7 months ago (2014-05-12 23:49:36 UTC) #4
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 7 months ago (2014-05-13 17:53:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/272223004/1
6 years, 7 months ago (2014-05-13 17:54:05 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 19:10:09 UTC) #7
Message was sent while issue was closed. 
Change committed as 173980

Powered by Google App Engine
This is Rietveld 408576698