content/renderer/media/android/webmediaplayer_android.h - Issue 275303002: Non-const impls. for WebMediaPlayer::didLoadingProgress().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 275303002: Non-const impls. for WebMediaPlayer::didLoadingProgress(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove mutable bools. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/android/webmediaplayer_android.h

diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h

index 9a6468a92b33baab673a0b8ec0f36fde640feeb5..5313faf3ab53b8140d7d2371d14c5891a4defdc3 100644

--- a/content/renderer/media/android/webmediaplayer_android.h

+++ b/content/renderer/media/android/webmediaplayer_android.h

@@ -132,7 +132,10 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,

virtual double timelineOffset() const;

virtual double currentTime() const;

+ // TODO(sandersd): Remove const version.

+ // http://crbug.com/360251

virtual bool didLoadingProgress() const;

+ virtual bool didLoadingProgress();

// Internal states of loading and network.

virtual blink::WebMediaPlayer::NetworkState networkState() const;

@@ -331,7 +334,7 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,

base::TimeDelta seek_time_;

// Whether loading has progressed since the last call to didLoadingProgress.

- mutable bool did_loading_progress_;

+ bool did_loading_progress_;

// Manager for managing this object and for delegating method calls on

// Render Thread.

« no previous file with comments | « no previous file | content/renderer/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »