Non-const impls. for WebMediaPlayer::didLoadingProgress().

content/renderer/media/android/webmediaplayer_android.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
 #define CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
 
 #include <jni.h>
 #include <string>
 #include <vector>
@@ skipping 114 matching lines @@
   // Dimensions of the video.
   virtual blink::WebSize naturalSize() const;
 
   // Getters of playback state.
   virtual bool paused() const;
   virtual bool seeking() const;
   virtual double duration() const;
   virtual double timelineOffset() const;
   virtual double currentTime() const;
 
+  // TODO(sandersd): Remove const version.
+  // http://crbug.com/360251
   virtual bool didLoadingProgress() const;
+  virtual bool didLoadingProgress();
 
   // Internal states of loading and network.
   virtual blink::WebMediaPlayer::NetworkState networkState() const;
   virtual blink::WebMediaPlayer::ReadyState readyState() const;
 
   virtual bool hasSingleSecurityOrigin() const;
   virtual bool didPassCORSAccessCheck() const;
 
   virtual double mediaTimeForTimeValue(double timeValue) const;
 
@@ skipping 178 matching lines @@
   // Seek gets pending if another seek is in progress. Only last pending seek
   // will have effect.
   bool pending_seek_;
   base::TimeDelta pending_seek_time_;
 
   // Internal seek state.
   bool seeking_;
   base::TimeDelta seek_time_;
 
   // Whether loading has progressed since the last call to didLoadingProgress.
   mutable bool did_loading_progress_;

[scherkus (not reviewing), 2014/05/09 22:39:18]

I think we can have this CL remove all the mutable stuff here + in Pipeline

then we can stick a const_cast<T*>(this)->didLoadingProgress() in the const
version of the method

[scherkus (not reviewing), 2014/05/09 22:40:21]

(doing it this way accomplishes the real goal of getting rid of "mutable"
everywhere and also isolates the grossness into the smallest possible spot: the
const versions of didLoadingProgress())

[sandersd (OOO until July 31), 2014/05/09 23:05:56]

Sure, I had that planned for the third CL, but I suppose there is no reason not
to do it right now.

 
   // Manager for managing this object and for delegating method calls on
   // Render Thread.
   RendererMediaPlayerManager* manager_;
 
   // Player ID assigned by the |manager_|.
   int player_id_;
 
   // Current player states.
   blink::WebMediaPlayer::NetworkState network_state_;
@@ skipping 99 matching lines @@
 
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<WebMediaPlayerAndroid> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerAndroid);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_