Factor gfx::Transform and skia_util into their own component.

Factor gfx::Transform and skia_util into their own component.

This allows us to remove a circular dependency between //cc/paint
and //ui/gfx that will arise when we add new classes in cc to
//cc/paint.

BUG=665259
Review-Url: https://codereview.chromium.org/2752693002
Cr-Commit-Position: refs/heads/master@{#457000}
Committed: https://chromium.googlesource.com/chromium/src/+/1f8b68a795ee37c7e22de5deeb0eadfb28ec7b08

[chrishtr, 2017-03-14 21:05:29]

Description was changed from

==========
none

BUG=
==========

to

==========
Factor gfx::Transform and skia_util into their own component.

This allows us to remove a circular dependency between //cc/paint
and //ui/gfx that will arise when we add new classes in cc to
//cc/paint.
==========

[chrishtr, 2017-03-14 21:05:41]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 21:06:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-14 21:14:23]

chrishtr@chromium.org changed reviewers:
+ danakj@chromium.org

[chrishtr, 2017-03-14 21:14:33]

Description was changed from

==========
Factor gfx::Transform and skia_util into their own component.

This allows us to remove a circular dependency between //cc/paint
and //ui/gfx that will arise when we add new classes in cc to
//cc/paint.
==========

to

==========
Factor gfx::Transform and skia_util into their own component.

This allows us to remove a circular dependency between //cc/paint
and //ui/gfx that will arise when we add new classes in cc to
//cc/paint.

BUG=665259
==========

[chrishtr, 2017-03-14 21:16:47]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 21:17:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-03-14 21:25:00]

https://codereview.chromium.org/2752693002/diff/20001/ui/gfx/BUILD.gn
File ui/gfx/BUILD.gn (right):

https://codereview.chromium.org/2752693002/diff/20001/ui/gfx/BUILD.gn#newcode24
ui/gfx/BUILD.gn:24: component("transform") {
Can you put these in geometry?

[danakj, 2017-03-14 21:26:02]

Uh.. this is a bit of a rabbit hole cuz that requires changing the path. But you
can leave forwarding headers to make the change easier, then search and replace
chunks of code at a time.

This shoulda been done a long time ago but no one had to do it till now.

[chrishtr, 2017-03-14 21:27:19]

I tried that, but got a mysterious error when adding a skia dependency to
ui/gfx/geometry: there is some include via ppapi that forces skia into an
architecture
it doesn't support. Error is:

"Need to port cpu specific stuff from skia_library_opts.gyp"

[danakj, 2017-03-14 21:29:16]

On 2017/03/14 21:27:19, chrishtr wrote:
> I tried that, but got a mysterious error when adding a skia dependency to
> ui/gfx/geometry: there is some include via ppapi that forces skia into an
> architecture
> it doesn't support. Error is:
> 
> "Need to port cpu specific stuff from skia_library_opts.gyp"

Oh, nacl probably..

[danakj, 2017-03-14 21:36:05]

https://codereview.chromium.org/2752693002/diff/20001/ui/gfx/BUILD.gn
File ui/gfx/BUILD.gn (right):

https://codereview.chromium.org/2752693002/diff/20001/ui/gfx/BUILD.gn#newcode24
ui/gfx/BUILD.gn:24: component("transform") {
On 2017/03/14 21:25:00, danakj wrote:
> Can you put these in geometry?

OK this is fine then but I just don't think skia_util inside "transform" makes
sense. Uhhhhmm.. how about skia_geometry?

[danakj, 2017-03-14 21:36:52]

N

https://codereview.chromium.org/2752693002/diff/20001/ui/gfx/BUILD.gn
File ui/gfx/BUILD.gn (right):

https://codereview.chromium.org/2752693002/diff/20001/ui/gfx/BUILD.gn#newcode24
ui/gfx/BUILD.gn:24: component("transform") {
On 2017/03/14 21:36:05, danakj wrote:
> On 2017/03/14 21:25:00, danakj wrote:
> > Can you put these in geometry?
> 
> OK this is fine then but I just don't think skia_util inside "transform" makes
> sense. Uhhhhmm.. how about skia_geometry?

Or geometry_skia.. maybe? Less namespacey?

[chrishtr, 2017-03-14 21:55:16]

On 2017/03/14 at 21:36:52, danakj wrote:
> N
> 
> https://codereview.chromium.org/2752693002/diff/20001/ui/gfx/BUILD.gn
> File ui/gfx/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2752693002/diff/20001/ui/gfx/BUILD.gn#newcode24
> ui/gfx/BUILD.gn:24: component("transform") {
> On 2017/03/14 21:36:05, danakj wrote:
> > On 2017/03/14 21:25:00, danakj wrote:
> > > Can you put these in geometry?
> > 
> > OK this is fine then but I just don't think skia_util inside "transform"
makes
> > sense. Uhhhhmm.. how about skia_geometry?
> 
> Or geometry_skia.. maybe? Less namespacey?

Done.

[danakj, 2017-03-15 00:10:11]

LGTM

[chrishtr, 2017-03-15 03:23:26]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-03-15 03:23:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 05:27:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489548206074190,
"parent_rev": "5b91c606652e6b648fc229a05573996510ef57ba", "commit_rev":
"1f8b68a795ee37c7e22de5deeb0eadfb28ec7b08"}

[commit-bot: I haz the power, 2017-03-15 05:28:47]

Description was changed from

==========
Factor gfx::Transform and skia_util into their own component.

This allows us to remove a circular dependency between //cc/paint
and //ui/gfx that will arise when we add new classes in cc to
//cc/paint.

BUG=665259
==========

to

==========
Factor gfx::Transform and skia_util into their own component.

This allows us to remove a circular dependency between //cc/paint
and //ui/gfx that will arise when we add new classes in cc to
//cc/paint.

BUG=665259

Review-Url: https://codereview.chromium.org/2752693002
Cr-Commit-Position: refs/heads/master@{#457000}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f8b68a795ee37c7e22de5deeb0e...
==========

[commit-bot: I haz the power, 2017-03-15 05:28:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1f8b68a795ee37c7e22de5deeb0e...