Move cc::DisplayItemList and related classes into cc/paint/

Move cc::DisplayItemList and related classes into cc/paint/

Also:

* The other classes in cc/playback/ have been moved into other directories
appropriate to their purpose.
* Add a component for cc/debug/ because otherwise cc/paint/ will depend on cc/
* Add a component for cc/base/ because otherwise cc/paint/ will depend on cc/
* Move cc/base/cc_export.h to cc/cc_export.h. This is the source of most of the
changes in this CL.

TBR=dcheng

BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2748263002
Cr-Commit-Position: refs/heads/master@{#457689}
Committed: https://chromium.googlesource.com/chromium/src/+/ac41ff944457de546ad75f2a19e4d6c2c14f2af0

[chrishtr, 2017-03-14 22:24:34]

Description was changed from

==========
Merge branch 'finalgn' into finalgn2


none

BUG=
==========

to

==========
Merge branch 'finalgn' into finalgn2


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chrishtr, 2017-03-14 22:25:41]

Description was changed from

==========
Merge branch 'finalgn' into finalgn2


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
playback -> cc/paint

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chrishtr, 2017-03-15 23:34:43]

Description was changed from

==========
playback -> cc/paint

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
playback -> cc/paint

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-15 23:35:53]

Description was changed from

==========
playback -> cc/paint

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move cc::DisplayItemList and related classes into cc/paint/

Also:

* The other classes in cc/playback/ have been moved into other directories
appropriate to their purpose.
* Add a component for cc/debug/ because otherwise cc/paint/ will depend on cc/
* Add a component for cc/base/ because otherwise cc/paint/ will depend on cc/
* Move cc/base/cc_export.h to cc/cc_export.h. This is the source of most of the
changes in this CL.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chrishtr, 2017-03-15 23:38:57]

chrishtr@chromium.org changed reviewers:
+ danakj@chromium.org, enne@chromium.org

[chrishtr, 2017-03-15 23:39:24]

Description was changed from

==========
Move cc::DisplayItemList and related classes into cc/paint/

Also:

* The other classes in cc/playback/ have been moved into other directories
appropriate to their purpose.
* Add a component for cc/debug/ because otherwise cc/paint/ will depend on cc/
* Add a component for cc/base/ because otherwise cc/paint/ will depend on cc/
* Move cc/base/cc_export.h to cc/cc_export.h. This is the source of most of the
changes in this CL.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move cc::DisplayItemList and related classes into cc/paint/

Also:

* The other classes in cc/playback/ have been moved into other directories
appropriate to their purpose.
* Add a component for cc/debug/ because otherwise cc/paint/ will depend on cc/
* Add a component for cc/base/ because otherwise cc/paint/ will depend on cc/
* Move cc/base/cc_export.h to cc/cc_export.h. This is the source of most of the
changes in this CL.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-15 23:50:41]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 23:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 23:51:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 23:51:16]

Dry run: CLs for remote refs other than refs/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[enne (OOO), 2017-03-16 00:51:15]

lgtm in general % danakj's review

I like moving the playback stuff into paint.  I think that fits with our future
goal of painting into cc display item lists.

Keeping debug and base separate seems fine to me.  I think anywhere that uses
them uses both, but I can understand it being complicated to try to put them in
the same library.

The cc changes all look pretty reasonable to me.  I suspect a lot of the
complicated stuff was in finding just the right slices of ui/gfx to prevent
cycles.

Thanks for making this happen.  :)

https://codereview.chromium.org/2748263002/diff/60001/cc/BUILD.gn
File cc/BUILD.gn (right):

https://codereview.chromium.org/2748263002/diff/60001/cc/BUILD.gn#newcode491
cc/BUILD.gn:491: "//cc/paint",
Could you put a TODO here to make this not public? I know you said you tried to
fix it up and couldn't figure out some mojo stuff.  I'm fine with landing the
rest of it, but at least leave a TODO that it'd be nice to not have to need the
paint stuff to use cc.

https://codereview.chromium.org/2748263002/diff/60001/cc/base/BUILD.gn
File cc/base/BUILD.gn (right):

https://codereview.chromium.org/2748263002/diff/60001/cc/base/BUILD.gn#newcode7
cc/base/BUILD.gn:7: component("cc_base") {
This can't be called base because it collides with //base's output, I'm
guessing?

Is there a way to make the component //cc/base but change the library name? 

gn help output_name suggests that maybe you can do:
  component("base") {
    output_name = "cc_base"
  }

https://codereview.chromium.org/2748263002/diff/60001/cc/debug/debug_colors.h
File cc/debug/debug_colors.h (left):

https://codereview.chromium.org/2748263002/diff/60001/cc/debug/debug_colors.h...
cc/debug/debug_colors.h:18: static int TiledContentLayerBorderWidth(const
LayerTreeImpl* tree_impl);
This is nice cleanup.

[chrishtr, 2017-03-16 02:00:35]

https://codereview.chromium.org/2748263002/diff/60001/cc/BUILD.gn
File cc/BUILD.gn (right):

https://codereview.chromium.org/2748263002/diff/60001/cc/BUILD.gn#newcode491
cc/BUILD.gn:491: "//cc/paint",
On 2017/03/16 at 00:51:15, enne wrote:
> Could you put a TODO here to make this not public? I know you said you tried
to fix it up and couldn't figure out some mojo stuff.  I'm fine with landing the
rest of it, but at least leave a TODO that it'd be nice to not have to need the
paint stuff to use cc.

Ok done.

https://codereview.chromium.org/2748263002/diff/60001/cc/base/BUILD.gn
File cc/base/BUILD.gn (right):

https://codereview.chromium.org/2748263002/diff/60001/cc/base/BUILD.gn#newcode7
cc/base/BUILD.gn:7: component("cc_base") {
On 2017/03/16 at 00:51:15, enne wrote:
> This can't be called base because it collides with //base's output, I'm
guessing?

Yes.
b
> 
> Is there a way to make the component //cc/base but change the library name? 
> 
> gn help output_name suggests that maybe you can do:
>   component("base") {
>     output_name = "cc_base"
>   }

Nice. That did the trick.

https://codereview.chromium.org/2748263002/diff/60001/cc/debug/debug_colors.h
File cc/debug/debug_colors.h (left):

https://codereview.chromium.org/2748263002/diff/60001/cc/debug/debug_colors.h...
cc/debug/debug_colors.h:18: static int TiledContentLayerBorderWidth(const
LayerTreeImpl* tree_impl);
On 2017/03/16 at 00:51:15, enne wrote:
> This is nice cleanup.

cool thanks

[chrishtr, 2017-03-16 02:59:24]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 02:59:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 03:18:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 03:18:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-03-16 03:56:44]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 03:57:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-16 03:58:33]

chrishtr@chromium.org changed reviewers:
+ dtrainor@chromium.org

[chrishtr, 2017-03-16 03:58:35]

+dtrainor for chrome/browser/android/compositor/layer/layer.h
+sky for ui/views/view_unittest.cc

[chrishtr, 2017-03-16 03:58:43]

chrishtr@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2017-03-16 04:27:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 04:27:16]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[chrishtr, 2017-03-16 05:22:40]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-03-16 05:23:03]

Description was changed from

==========
Move cc::DisplayItemList and related classes into cc/paint/

Also:

* The other classes in cc/playback/ have been moved into other directories
appropriate to their purpose.
* Add a component for cc/debug/ because otherwise cc/paint/ will depend on cc/
* Add a component for cc/base/ because otherwise cc/paint/ will depend on cc/
* Move cc/base/cc_export.h to cc/cc_export.h. This is the source of most of the
changes in this CL.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move cc::DisplayItemList and related classes into cc/paint/

Also:

* The other classes in cc/playback/ have been moved into other directories
appropriate to their purpose.
* Add a component for cc/debug/ because otherwise cc/paint/ will depend on cc/
* Add a component for cc/base/ because otherwise cc/paint/ will depend on cc/
* Move cc/base/cc_export.h to cc/cc_export.h. This is the source of most of the
changes in this CL.

BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-03-16 05:23:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 05:53:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 05:53:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[David Trainor- moved to gerrit, 2017-03-16 06:02:12]

chrome/browser/android/compositor/layer/layer.h lgtm

[sky, 2017-03-16 16:12:29]

ui/views LGTM

[danakj, 2017-03-16 16:23:13]

I think FilterOperations could go in cc/base/, then cc/animation/ doesn't dep on
cc/paint.

Same for RenderSurfaceFilters. These are fundamentally used in other parts of cc
including cc/surfaces, so it seems like something that belongs in a "common"
directory which is what cc/base/ is.

https://codereview.chromium.org/2748263002/diff/140001/cc/BUILD.gn
File cc/BUILD.gn (right):

https://codereview.chromium.org/2748263002/diff/140001/cc/BUILD.gn#newcode10
cc/BUILD.gn:10: "debug/benchmark_instrumentation.cc",
What's the story with the rest of the debug directory? It's odd to have a
cc/debug/ component that doesn't include all the files there.

[chrishtr, 2017-03-16 16:30:39]

On 2017/03/16 at 16:23:13, danakj wrote:
> I think FilterOperations could go in cc/base/, then cc/animation/ doesn't dep
on cc/paint.
> 
> Same for RenderSurfaceFilters. These are fundamentally used in other parts of
cc including cc/surfaces, so it seems like something that belongs in a "common"
directory which is what cc/base/ is.

Ok, working on that now.

> 
> https://codereview.chromium.org/2748263002/diff/140001/cc/BUILD.gn
> File cc/BUILD.gn (right):
> 
> https://codereview.chromium.org/2748263002/diff/140001/cc/BUILD.gn#newcode10
> cc/BUILD.gn:10: "debug/benchmark_instrumentation.cc",
> What's the story with the rest of the debug directory? It's odd to have a
cc/debug/ component that doesn't include all the files there.

They are all benchmark-related files. How about I move them to a
cc/benchmarking/ directory in a subsequent patch?

[danakj, 2017-03-16 16:36:36]

On Thu, Mar 16, 2017 at 12:30 PM, <chrishtr@chromium.org> wrote:

> On 2017/03/16 at 16:23:13, danakj wrote:
> > I think FilterOperations could go in cc/base/, then cc/animation/
> doesn't dep
> on cc/paint.
> >
> > Same for RenderSurfaceFilters. These are fundamentally used in other
> parts of
> cc including cc/surfaces, so it seems like something that belongs in a
> "common"
> directory which is what cc/base/ is.
>
> Ok, working on that now.
>
> >
> > https://codereview.chromium.org/2748263002/diff/140001/cc/BUILD.gn
> > File cc/BUILD.gn (right):
> >
> > https://codereview.chromium.org/2748263002/diff/140001/cc/
> BUILD.gn#newcode10
> > cc/BUILD.gn:10: "debug/benchmark_instrumentation.cc",
> > What's the story with the rest of the debug directory? It's odd to have a
> cc/debug/ component that doesn't include all the files there.
>
> They are all benchmark-related files. How about I move them to a
> cc/benchmarking/ directory in a subsequent patch?
>

That seems good. Is it problematic to put them in debug/ until then? If so
I'm okay with it as is with the followup.


>
> https://codereview.chromium.org/2748263002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chrishtr, 2017-03-16 16:40:53]

On 2017/03/16 at 16:36:36, danakj wrote:
> On Thu, Mar 16, 2017 at 12:30 PM, <chrishtr@chromium.org> wrote:
> 
> > On 2017/03/16 at 16:23:13, danakj wrote:
> > > I think FilterOperations could go in cc/base/, then cc/animation/
> > doesn't dep
> > on cc/paint.
> > >
> > > Same for RenderSurfaceFilters. These are fundamentally used in other
> > parts of
> > cc including cc/surfaces, so it seems like something that belongs in a
> > "common"
> > directory which is what cc/base/ is.
> >
> > Ok, working on that now.
> >
> > >
> > > https://codereview.chromium.org/2748263002/diff/140001/cc/BUILD.gn
> > > File cc/BUILD.gn (right):
> > >
> > > https://codereview.chromium.org/2748263002/diff/140001/cc/
> > BUILD.gn#newcode10
> > > cc/BUILD.gn:10: "debug/benchmark_instrumentation.cc",
> > > What's the story with the rest of the debug directory? It's odd to have a
> > cc/debug/ component that doesn't include all the files there.
> >
> > They are all benchmark-related files. How about I move them to a
> > cc/benchmarking/ directory in a subsequent patch?
> >
> 
> That seems good. Is it problematic to put them in debug/ until then? If so
> I'm okay with it as is with the followup.

Yes it is problematic. It causes a bunch of dependency issues.

> 
> 
> >
> > https://codereview.chromium.org/2748263002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to chromium-reviews+unsubscribe@chromium.org.
>

[danakj, 2017-03-16 17:00:24]

Poked thru the rest and it looks good

https://codereview.chromium.org/2748263002/diff/160001/cc/ipc/BUILD.gn
File cc/ipc/BUILD.gn (right):

https://codereview.chromium.org/2748263002/diff/160001/cc/ipc/BUILD.gn#newcode23
cc/ipc/BUILD.gn:23: "//cc/paint",
looks like this is only for FilterOps so would go away

[chrishtr, 2017-03-16 17:07:47]

Ok all changes now made. cc/animation and cc/ipc no longer depend on cc/paint.

[chrishtr, 2017-03-16 17:07:54]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 17:08:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-03-16 17:14:06]

LGTM

https://codereview.chromium.org/2748263002/diff/140001/cc/BUILD.gn
File cc/BUILD.gn (right):

https://codereview.chromium.org/2748263002/diff/140001/cc/BUILD.gn#newcode480
cc/BUILD.gn:480: # TODO(chrishtr): this should be in deps, not public_deps. It's
Oh yay

https://codereview.chromium.org/2748263002/diff/210001/cc/animation/BUILD.gn
File cc/animation/BUILD.gn (right):

https://codereview.chromium.org/2748263002/diff/210001/cc/animation/BUILD.gn#...
cc/animation/BUILD.gn:49: "//cc/base",
base is a public dep of //cc so not needed here right?

[commit-bot: I haz the power, 2017-03-16 17:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 17:15:52]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[chrishtr, 2017-03-16 17:43:23]

https://codereview.chromium.org/2748263002/diff/210001/cc/animation/BUILD.gn
File cc/animation/BUILD.gn (right):

https://codereview.chromium.org/2748263002/diff/210001/cc/animation/BUILD.gn#...
cc/animation/BUILD.gn:49: "//cc/base",
On 2017/03/16 at 17:14:06, danakj wrote:
> base is a public dep of //cc so not needed here right?

Indeed! Removed.

[chrishtr, 2017-03-16 18:18:30]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-16 18:18:32]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org,
dtrainor@chromium.org, sky@chromium.org, danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2748263002/#ps230001
(title: "none")

[commit-bot: I haz the power, 2017-03-16 18:19:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-16 18:22:08]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-03-16 18:22:47]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-16 18:22:52]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
dtrainor@chromium.org, sky@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2748263002/#ps250001
(title: "none")

[commit-bot: I haz the power, 2017-03-16 18:23:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 18:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 18:33:29]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-03-16 18:43:41]

chrishtr@chromium.org changed reviewers:
+ dcheng@chromium.org

[chrishtr, 2017-03-16 18:43:43]

+dcheng for cc/ipc

[chrishtr, 2017-03-16 18:45:33]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 18:46:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-03-16 19:08:00]

On Thu, Mar 16, 2017 at 2:43 PM, <chrishtr@chromium.org> wrote:

> +dcheng for cc/ipc
>

There are no changes to any messages, you should TBR I think.


>
> https://codereview.chromium.org/2748263002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chrishtr, 2017-03-16 19:41:05]

Description was changed from

==========
Move cc::DisplayItemList and related classes into cc/paint/

Also:

* The other classes in cc/playback/ have been moved into other directories
appropriate to their purpose.
* Add a component for cc/debug/ because otherwise cc/paint/ will depend on cc/
* Add a component for cc/base/ because otherwise cc/paint/ will depend on cc/
* Move cc/base/cc_export.h to cc/cc_export.h. This is the source of most of the
changes in this CL.

BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move cc::DisplayItemList and related classes into cc/paint/

Also:

* The other classes in cc/playback/ have been moved into other directories
appropriate to their purpose.
* Add a component for cc/debug/ because otherwise cc/paint/ will depend on cc/
* Add a component for cc/base/ because otherwise cc/paint/ will depend on cc/
* Move cc/base/cc_export.h to cc/cc_export.h. This is the source of most of the
changes in this CL.

TBR=dcheng

BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-16 19:41:15]

OK TBR then.

[chrishtr, 2017-03-16 19:41:19]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-03-16 19:41:22]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-16 19:41:23]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
dtrainor@chromium.org, sky@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2748263002/#ps270001
(title: "none")

[commit-bot: I haz the power, 2017-03-16 19:41:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-16 20:09:06]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-16 20:09:07]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
dtrainor@chromium.org, sky@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2748263002/#ps290001
(title: "none")

[commit-bot: I haz the power, 2017-03-16 20:09:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-16 21:38:14]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-16 21:38:16]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
dtrainor@chromium.org, sky@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2748263002/#ps310001
(title: "none")

[commit-bot: I haz the power, 2017-03-16 21:38:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-03-16 21:40:10]

rs lgtm for ipc changes

[chrishtr, 2017-03-16 22:14:25]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-16 22:14:27]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
dtrainor@chromium.org, sky@chromium.org, dcheng@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2748263002/#ps330001
(title: "none")

[commit-bot: I haz the power, 2017-03-16 22:15:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 01:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 01:11:37]

Failed to apply patch for cc/raster/raster_source.cc:
While running git apply --index -p1;
  error: patch failed: cc/playback/raster_source.cc:11
  error: cc/playback/raster_source.cc: patch does not apply

Patch:   NR  cc/playback/raster_source.cc->cc/raster/raster_source.cc
Index: cc/raster/raster_source.cc
diff --git a/cc/playback/raster_source.cc b/cc/raster/raster_source.cc
similarity index 98%
rename from cc/playback/raster_source.cc
rename to cc/raster/raster_source.cc
index
e15a91968c385393cb4ecbb6ec5e61d44c872e73..c8454cb1eb0da62e51c042c47b700712e0db132e
100644
--- a/cc/playback/raster_source.cc
+++ b/cc/raster/raster_source.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "cc/playback/raster_source.h"
+#include "cc/raster/raster_source.h"
 
 #include <stddef.h>
 
@@ -11,9 +11,9 @@
 #include "cc/base/region.h"
 #include "cc/debug/debug_colors.h"
 #include "cc/debug/traced_value.h"
-#include "cc/playback/display_item_list.h"
-#include "cc/playback/image_hijack_canvas.h"
-#include "cc/playback/skip_image_canvas.h"
+#include "cc/paint/display_item_list.h"
+#include "cc/raster/image_hijack_canvas.h"
+#include "cc/raster/skip_image_canvas.h"
 #include "skia/ext/analysis_canvas.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "third_party/skia/include/core/SkPictureRecorder.h"
@@ -57,8 +57,7 @@ RasterSource::RasterSource(const RasterSource* other, bool
can_use_lcd_text)
           other->slow_down_raster_scale_factor_for_debug_),
       image_decode_cache_(other->image_decode_cache_) {}
 
-RasterSource::~RasterSource() {
-}
+RasterSource::~RasterSource() {}
 
 void RasterSource::PlaybackToCanvas(SkCanvas* raster_canvas,
                                     const gfx::Rect& canvas_bitmap_rect,

[chrishtr, 2017-03-17 01:14:21]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-03-17 01:14:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-17 01:17:02]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-17 01:17:04]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
dtrainor@chromium.org, sky@chromium.org, dcheng@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2748263002/#ps350001
(title: "Merge branch 'master' into ccpaint")

[commit-bot: I haz the power, 2017-03-17 01:17:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 05:07:36]

CQ is committing da patch.

Bot data: {"patchset_id": 350001, "attempt_start_ts": 1489713422331100,
"parent_rev": "24d294391f1a0fce66fa1802d09f9e4a89a94841", "commit_rev":
"ac41ff944457de546ad75f2a19e4d6c2c14f2af0"}

[commit-bot: I haz the power, 2017-03-17 05:09:02]

Description was changed from

==========
Move cc::DisplayItemList and related classes into cc/paint/

Also:

* The other classes in cc/playback/ have been moved into other directories
appropriate to their purpose.
* Add a component for cc/debug/ because otherwise cc/paint/ will depend on cc/
* Add a component for cc/base/ because otherwise cc/paint/ will depend on cc/
* Move cc/base/cc_export.h to cc/cc_export.h. This is the source of most of the
changes in this CL.

TBR=dcheng

BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move cc::DisplayItemList and related classes into cc/paint/

Also:

* The other classes in cc/playback/ have been moved into other directories
appropriate to their purpose.
* Add a component for cc/debug/ because otherwise cc/paint/ will depend on cc/
* Add a component for cc/base/ because otherwise cc/paint/ will depend on cc/
* Move cc/base/cc_export.h to cc/cc_export.h. This is the source of most of the
changes in this CL.

TBR=dcheng

BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2748263002
Cr-Commit-Position: refs/heads/master@{#457689}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac41ff944457de546ad75f2a19e4...
==========

[commit-bot: I haz the power, 2017-03-17 05:09:05]

Committed patchset #19 (id:350001) as
https://chromium.googlesource.com/chromium/src/+/ac41ff944457de546ad75f2a19e4...