Move ui/gfx/animation/ into its own component.

Move ui/gfx/animation/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2750743003
Cr-Commit-Position: refs/heads/master@{#457084}
Committed: https://chromium.googlesource.com/chromium/src/+/bdbe31846363ad6d21641f39a49628bcdb879e7f

[chrishtr, 2017-03-14 22:17:42]

Description was changed from

==========
none

BUG=
==========

to

==========
Move ui/gfx/animation/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

BUG=665259
==========

[chrishtr, 2017-03-14 22:20:54]

chrishtr@chromium.org changed reviewers:
+ boliu@chromium.org, danakj@chromium.org, pkasting@chromium.org

[chrishtr, 2017-03-14 22:22:57]

chrishtr@chromium.org changed reviewers:
+ sky@chromium.org

[chrishtr, 2017-03-14 22:22:57]

ui: sky
content/browser: boliu
components/infobars: pkasting

[chrishtr, 2017-03-14 22:23:03]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 22:23:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-03-14 22:28:07]

On 2017/03/14 22:22:57, chrishtr wrote:
> ui: sky
> content/browser: boliu

rs lgtm

> components/infobars: pkasting

[commit-bot: I haz the power, 2017-03-14 22:29:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 22:29:28]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chrishtr, 2017-03-14 22:43:10]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 22:44:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-03-14 22:49:25]

LGTM

[commit-bot: I haz the power, 2017-03-14 22:49:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 22:49:58]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[chrishtr, 2017-03-14 22:54:05]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 22:55:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 23:01:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 23:01:01]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chrishtr, 2017-03-14 23:05:06]

Description was changed from

==========
Move ui/gfx/animation/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

BUG=665259
==========

to

==========
Move ui/gfx/animation/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chrishtr, 2017-03-14 23:05:21]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 23:05:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 23:12:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 23:12:55]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[chrishtr, 2017-03-14 23:26:19]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 23:26:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 23:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 23:41:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sky, 2017-03-14 23:53:09]

LGTM

https://codereview.chromium.org/2750743003/diff/160001/ui/gfx/animation/BUILD.gn
File ui/gfx/animation/BUILD.gn (right):

https://codereview.chromium.org/2750743003/diff/160001/ui/gfx/animation/BUILD...
ui/gfx/animation/BUILD.gn:36: # Android.
Remove this comment as it's obvious given the next line (you don't have the same
comment on line 7).

https://codereview.chromium.org/2750743003/diff/160001/ui/gfx/animation/anima...
File ui/gfx/animation/animation_export.h (right):

https://codereview.chromium.org/2750743003/diff/160001/ui/gfx/animation/anima...
ui/gfx/animation/animation_export.h:1: // Copyright (c) 2017 The Chromium
Authors. All rights reserved.
no (c)

[danakj, 2017-03-15 00:08:01]

https://codereview.chromium.org/2750743003/diff/160001/cc/debug/BUILD.gn
File cc/debug/BUILD.gn (right):

https://codereview.chromium.org/2750743003/diff/160001/cc/debug/BUILD.gn#newc...
cc/debug/BUILD.gn:9: "debug_colors.cc",
These should be removed from cc/BUILD.gn then right?

[danakj, 2017-03-15 00:08:30]

https://codereview.chromium.org/2750743003/diff/160001/cc/debug/BUILD.gn
File cc/debug/BUILD.gn (right):

https://codereview.chromium.org/2750743003/diff/160001/cc/debug/BUILD.gn#newc...
cc/debug/BUILD.gn:6: cc_component("debug") {
Also just checking why a component and not a source set like //cc/base ?

[chrishtr, 2017-03-15 03:26:36]

https://codereview.chromium.org/2750743003/diff/160001/cc/debug/BUILD.gn
File cc/debug/BUILD.gn (right):

https://codereview.chromium.org/2750743003/diff/160001/cc/debug/BUILD.gn#newc...
cc/debug/BUILD.gn:6: cc_component("debug") {
On 2017/03/15 at 00:08:30, danakj wrote:
> Also just checking why a component and not a source set like //cc/base ?

I accidentally added this in the latest patchset. Removed, it'll be in a
future CL.

https://codereview.chromium.org/2750743003/diff/160001/cc/debug/BUILD.gn#newc...
cc/debug/BUILD.gn:9: "debug_colors.cc",
On 2017/03/15 at 00:08:00, danakj wrote:
> These should be removed from cc/BUILD.gn then right?

ditto

https://codereview.chromium.org/2750743003/diff/160001/ui/gfx/animation/BUILD.gn
File ui/gfx/animation/BUILD.gn (right):

https://codereview.chromium.org/2750743003/diff/160001/ui/gfx/animation/BUILD...
ui/gfx/animation/BUILD.gn:36: # Android.
On 2017/03/14 at 23:53:08, sky wrote:
> Remove this comment as it's obvious given the next line (you don't have the
same comment on line 7).

Done.

https://codereview.chromium.org/2750743003/diff/160001/ui/gfx/animation/anima...
File ui/gfx/animation/animation_export.h (right):

https://codereview.chromium.org/2750743003/diff/160001/ui/gfx/animation/anima...
ui/gfx/animation/animation_export.h:1: // Copyright (c) 2017 The Chromium
Authors. All rights reserved.
On 2017/03/14 at 23:53:08, sky wrote:
> no (c)

Fixed.

[chrishtr, 2017-03-15 03:44:25]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-15 03:44:26]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
pkasting@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2750743003/#ps200001
(title: "none")

[commit-bot: I haz the power, 2017-03-15 03:44:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 03:44:50]

This CL has an open dependency (Issue 2752693002 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[chrishtr, 2017-03-15 03:54:45]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 03:55:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 04:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 04:55:52]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[chrishtr, 2017-03-15 14:18:15]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-15 14:18:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, boliu@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2750743003/#ps220001
(title: "c")

[commit-bot: I haz the power, 2017-03-15 14:18:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 15:15:47]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1489587495109790,
"parent_rev": "3a87cbc4fe0ad88df511929517797a10b9879361", "commit_rev":
"bdbe31846363ad6d21641f39a49628bcdb879e7f"}

[commit-bot: I haz the power, 2017-03-15 15:16:32]

Description was changed from

==========
Move ui/gfx/animation/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move ui/gfx/animation/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2750743003
Cr-Commit-Position: refs/heads/master@{#457084}
Committed:
https://chromium.googlesource.com/chromium/src/+/bdbe31846363ad6d21641f39a496...
==========

[commit-bot: I haz the power, 2017-03-15 15:16:33]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/bdbe31846363ad6d21641f39a496...