Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: ui/gfx/BUILD.gn

Issue 2752693002: Factor gfx::Transform and skia_util into their own component. (Closed)
Patch Set: none Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/gfx/skia_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 import("//testing/libfuzzer/fuzzer_test.gni") 7 import("//testing/libfuzzer/fuzzer_test.gni")
8 8
9 if (is_android) { 9 if (is_android) {
10 import("//build/config/android/config.gni") 10 import("//build/config/android/config.gni")
11 import("//build/config/android/rules.gni") 11 import("//build/config/android/rules.gni")
12 } 12 }
13 13
14 # Several targets want to include this header file, and some of them are 14 # Several targets want to include this header file, and some of them are
15 # child dependencies of "gfx". Therefore, we separate it out here so multiple 15 # child dependencies of "gfx". Therefore, we separate it out here so multiple
16 # targets can all have a dependency for header checking purposes without 16 # targets can all have a dependency for header checking purposes without
17 # creating circular dependencies. 17 # creating circular dependencies.
18 source_set("gfx_export") { 18 source_set("gfx_export") {
19 sources = [ 19 sources = [
20 "gfx_export.h", 20 "gfx_export.h",
21 ] 21 ]
22 } 22 }
23 23
24 component("transform") {
danakj 2017/03/14 21:25:00 Can you put these in geometry?
danakj 2017/03/14 21:36:05 OK this is fine then but I just don't think skia_u
danakj 2017/03/14 21:36:52 Or geometry_skia.. maybe? Less namespacey?
25 sources = [
26 "skia_util.cc",
27 "skia_util.h",
28 "transform.cc",
29 "transform.h",
30 "transform_util.cc",
31 "transform_util.h",
32 ]
33 public_deps = [
34 ":gfx_export",
35 ]
36 deps = [
37 "//base",
38 "//skia",
39 "//ui/gfx/geometry",
40 ]
41 defines = [ "GFX_IMPLEMENTATION" ]
42 }
43
24 component("gfx") { 44 component("gfx") {
25 sources = [ 45 sources = [
26 "android/gfx_jni_registrar.cc", 46 "android/gfx_jni_registrar.cc",
27 "android/gfx_jni_registrar.h", 47 "android/gfx_jni_registrar.h",
28 "android/java_bitmap.cc", 48 "android/java_bitmap.cc",
29 "android/java_bitmap.h", 49 "android/java_bitmap.h",
30 "android/view_configuration.cc", 50 "android/view_configuration.cc",
31 "android/view_configuration.h", 51 "android/view_configuration.h",
32 "animation/animation.cc", 52 "animation/animation.cc",
33 "animation/animation.h", 53 "animation/animation.h",
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 "selection_model.cc", 185 "selection_model.cc",
166 "selection_model.h", 186 "selection_model.h",
167 "sequential_id_generator.cc", 187 "sequential_id_generator.cc",
168 "sequential_id_generator.h", 188 "sequential_id_generator.h",
169 "shadow_value.cc", 189 "shadow_value.cc",
170 "shadow_value.h", 190 "shadow_value.h",
171 "skbitmap_operations.cc", 191 "skbitmap_operations.cc",
172 "skbitmap_operations.h", 192 "skbitmap_operations.h",
173 "skia_color_space_util.cc", 193 "skia_color_space_util.cc",
174 "skia_color_space_util.h", 194 "skia_color_space_util.h",
175 "skia_util.cc",
176 "skia_util.h",
177 "switches.cc", 195 "switches.cc",
178 "switches.h", 196 "switches.h",
179 "sys_color_change_listener.cc", 197 "sys_color_change_listener.cc",
180 "sys_color_change_listener.h", 198 "sys_color_change_listener.h",
181 "text_constants.h", 199 "text_constants.h",
182 "text_elider.cc", 200 "text_elider.cc",
183 "text_elider.h", 201 "text_elider.h",
184 "text_utils.cc", 202 "text_utils.cc",
185 "text_utils.h", 203 "text_utils.h",
186 "text_utils_android.cc", 204 "text_utils_android.cc",
187 "text_utils_ios.mm", 205 "text_utils_ios.mm",
188 "transform.cc",
189 "transform.h",
190 "transform_util.cc",
191 "transform_util.h",
192 "ui_gfx_exports.cc", 206 "ui_gfx_exports.cc",
193 "utf16_indexing.cc", 207 "utf16_indexing.cc",
194 "utf16_indexing.h", 208 "utf16_indexing.h",
195 "vsync_provider.cc", 209 "vsync_provider.cc",
196 "vsync_provider.h", 210 "vsync_provider.h",
197 "win/direct_manipulation.cc", 211 "win/direct_manipulation.cc",
198 "win/direct_manipulation.h", 212 "win/direct_manipulation.h",
199 "win/direct_write.cc", 213 "win/direct_write.cc",
200 "win/direct_write.h", 214 "win/direct_write.h",
201 "win/hwnd_util.cc", 215 "win/hwnd_util.cc",
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 ] 262 ]
249 263
250 # This is part of the gfx component in the component build. 264 # This is part of the gfx component in the component build.
251 defines = [ "GFX_IMPLEMENTATION" ] 265 defines = [ "GFX_IMPLEMENTATION" ]
252 266
253 public_deps = [ 267 public_deps = [
254 ":color_space", 268 ":color_space",
255 ":memory_buffer_sources", 269 ":memory_buffer_sources",
256 ":native_widget_types", 270 ":native_widget_types",
257 ":selection_bound_sources", 271 ":selection_bound_sources",
272 ":transform",
258 "//base", 273 "//base",
259 "//skia", 274 "//skia",
260 "//third_party/icu", 275 "//third_party/icu",
261 "//ui/gfx/geometry", 276 "//ui/gfx/geometry",
262 "//ui/gfx/range", 277 "//ui/gfx/range",
263 ] 278 ]
264 deps = [ 279 deps = [
265 ":gfx_export", 280 ":gfx_export",
266 "//base", 281 "//base",
267 "//base:base_static", 282 "//base:base_static",
(...skipping 503 matching lines...) Expand 10 before | Expand all | Expand 10 after
771 786
772 fuzzer_test("color_transform_fuzztest") { 787 fuzzer_test("color_transform_fuzztest") {
773 sources = [ 788 sources = [
774 "color_transform_fuzzer.cc", 789 "color_transform_fuzzer.cc",
775 ] 790 ]
776 deps = [ 791 deps = [
777 ":gfx", 792 ":gfx",
778 ] 793 ]
779 libfuzzer_options = [ "max_len=1024" ] 794 libfuzzer_options = [ "max_len=1024" ]
780 } 795 }
OLDNEW
« no previous file with comments | « no previous file | ui/gfx/skia_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698