Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2751623002: Revert of Server push cancellation: add a finch trial parameter (patchset #14 id:280001 of https://… (Closed)

Created:
3 years, 9 months ago by Zhongyi Shi
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Revert of Server push cancellation: add a finch trial parameter (patchset #14 id:280001 of https://codereview.chromium.org/2692813002/ ) Reason for revert: Broke MSAN https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/698 Is enable_server_push_cancellation initialized? Original issue's description: > Server push cancellation: add a finch trial parameter > "enable_server_push_cancellation" to control the feature of server push > cancellation. Create a HttpCacheLookupManager in HttpCache's constructor > and set it to HttpNetworkSession which will set it thru reaching > QuicChromiumClientSession and SpdySession. > > BUG=232040 > > Review-Url: https://codereview.chromium.org/2692813002 > Cr-Commit-Position: refs/heads/master@{#454457} > Committed: https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7a8cd805f13e8 R=rch@chromium.org TBR=ckrasic@chromium.org, rch@chromium.org, zhongyi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=232040 Review-Url: https://codereview.chromium.org/2730053002 Cr-Commit-Position: refs/heads/master@{#454554} (cherry picked from commit cfb060c669c937702a4ede2d59ae71ae48aafdc3) Review-Url: https://codereview.chromium.org/2751623002 . Cr-Commit-Position: refs/branch-heads/3029@{#187} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/f260d6b6ba529ac09689e0755e4674632f9bb753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -330 lines) Patch
M components/network_session_configurator/network_session_configurator.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M net/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_cache.cc View 2 chunks +8 lines, -15 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_dispatcher.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/tools/quic/quic_simple_dispatcher.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_session_visitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_quic_unittest.cc View 5 chunks +0 lines, -230 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Zhongyi Shi
3 years, 9 months ago (2017-03-14 00:27:55 UTC) #1
Zhongyi Shi
Cherry-picking the revert from M59 to M58 since the M58 cut in between. 454457 Original ...
3 years, 9 months ago (2017-03-14 00:28:38 UTC) #2
Ryan Hamilton
lgtm
3 years, 9 months ago (2017-03-14 00:49:55 UTC) #3
Zhongyi Shi
3 years, 9 months ago (2017-03-14 16:34:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f260d6b6ba529ac09689e0755e4674632f9bb753 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698