Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1441)

Unified Diff: net/http/http_network_session.cc

Issue 2751623002: Revert of Server push cancellation: add a finch trial parameter (patchset #14 id:280001 of https://… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_session.h ('k') | net/quic/core/quic_server_session_base_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_session.cc
diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc
index 54fe15936aae01334451793d747091027b35a6eb..b57653a3b77aea99af3d6904e8f0ee6f2e0a37fd 100644
--- a/net/http/http_network_session.cc
+++ b/net/http/http_network_session.cc
@@ -398,9 +398,7 @@ bool HttpNetworkSession::IsProtocolEnabled(NextProto protocol) const {
void HttpNetworkSession::SetServerPushDelegate(
std::unique_ptr<ServerPushDelegate> push_delegate) {
- DCHECK(push_delegate);
- if (!params_.enable_server_push_cancellation || push_delegate_)
- return;
+ DCHECK(!push_delegate_ && push_delegate);
push_delegate_ = std::move(push_delegate);
spdy_session_pool_.set_server_push_delegate(push_delegate_.get());
« no previous file with comments | « net/http/http_network_session.h ('k') | net/quic/core/quic_server_session_base_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698