Server push cancellation: add a finch trial parameter

Server push cancellation: add a finch trial parameter
"enable_server_push_cancellation" to control the feature of server push
cancellation. Create a HttpCacheLookupManager in HttpCache's constructor
and set it to HttpNetworkSession which will set it thru reaching
QuicChromiumClientSession and SpdySession.

BUG=232040
Review-Url: https://codereview.chromium.org/2692813002
Cr-Original-Original-Commit-Position: refs/heads/master@{#454457}
Committed: https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7a8cd805f13e8
Review-Url: https://codereview.chromium.org/2692813002
Cr-Original-Commit-Position: refs/heads/master@{#454679}
Committed: https://chromium.googlesource.com/chromium/src/+/f04bd2c84154b59a3d870993051df4be0b13964f
Review-Url: https://codereview.chromium.org/2692813002
Cr-Commit-Position: refs/heads/master@{#464737}
Committed: https://chromium.googlesource.com/chromium/src/+/d7dd2db1ad3596d682aa7fd56d3fef6f218250ec

[Zhongyi Shi, 2017-02-16 07:33:11]

Patchset #3 (id:40001) has been deleted

[Zhongyi Shi, 2017-02-16 07:33:52]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 07:34:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2017-02-16 07:39:49]

zhongyi@chromium.org changed reviewers:
+ ckrasic@chromium.org, rch@chromium.org

[Zhongyi Shi, 2017-02-16 07:39:50]

Ryan and Buck,

integration tests for server push cancellation, ptal! Let me if we have better
ways to verify the status.

Was wondering whether we could check the |server_| receives RST_STREAM with
QUIC_STREAM_CANCELLED. Haven't figured out how to extract server logging.

https://codereview.chromium.org/2692813002/diff/100001/net/url_request/url_re...
File net/url_request/url_request_quic_unittest.cc (right):

https://codereview.chromium.org/2692813002/diff/100001/net/url_request/url_re...
net/url_request/url_request_quic_unittest.cc:241: TEST_F(URLRequestQuicTest,
CancelPushIfCached) {
Currently the server push cancellation status is verified through the NetLogs on
the client, which is similar to the manual testing I have done before. Let me
know, if we have any better alternatives to verify.

[Ryan Hamilton, 2017-02-16 15:15:07]

Sweet. Will think more about the test.

https://codereview.chromium.org/2692813002/diff/100001/net/http/http_cache.cc
File net/http/http_cache.cc (right):

https://codereview.chromium.org/2692813002/diff/100001/net/http/http_cache.cc...
net/http/http_cache.cc:322: if (session) {
nit: as long as you're here:

if (!session)
  return;

net_log_ = session->net_log();
if (!is_main_cache)
  return

...

https://codereview.chromium.org/2692813002/diff/100001/net/http/http_network_...
File net/http/http_network_session.h (right):

https://codereview.chromium.org/2692813002/diff/100001/net/http/http_network_...
net/http/http_network_session.h:328: bool enable_server_push_cancellation_;
It's surprising to see this field as a member of HttpNetworkSession. Can we use
the field in params_ instead?

[Ryan Hamilton, 2017-02-16 15:18:09]

https://codereview.chromium.org/2692813002/diff/100001/net/url_request/url_re...
File net/url_request/url_request_quic_unittest.cc (right):

https://codereview.chromium.org/2692813002/diff/100001/net/url_request/url_re...
net/url_request/url_request_quic_unittest.cc:241: TEST_F(URLRequestQuicTest,
CancelPushIfCached) {
On 2017/02/16 07:39:50, Zhongyi Shi wrote:
> Currently the server push cancellation status is verified through the NetLogs
on
> the client, which is similar to the manual testing I have done before. Let me
> know, if we have any better alternatives to verify.

One idea might be for the QUIC server to expose the number of requests it has
handled. So after each request in complete in the client, you could check the
server's count to see if it has moved as expected. It could also expose a reset
stream count as well.

[Zhongyi Shi, 2017-02-19 20:19:53]

Added a new method in QuicSession::Visitor to collect reset(s) received from the
peer. Make QuicDispatcher implement the method to collect reset error stats for
server so that we could verify the resets received on the server side due to
server push cancellation.

The internal cl is also cooked up at 147952503.

PTAL, thanks!

https://codereview.chromium.org/2692813002/diff/100001/net/http/http_cache.cc
File net/http/http_cache.cc (right):

https://codereview.chromium.org/2692813002/diff/100001/net/http/http_cache.cc...
net/http/http_cache.cc:322: if (session) {
On 2017/02/16 15:15:07, Ryan Hamilton wrote:
> nit: as long as you're here:
> 
> if (!session)
>   return;
> 
> net_log_ = session->net_log();
> if (!is_main_cache)
>   return
> 
> ...

Done.

https://codereview.chromium.org/2692813002/diff/100001/net/http/http_network_...
File net/http/http_network_session.h (right):

https://codereview.chromium.org/2692813002/diff/100001/net/http/http_network_...
net/http/http_network_session.h:328: bool enable_server_push_cancellation_;
On 2017/02/16 15:15:07, Ryan Hamilton wrote:
> It's surprising to see this field as a member of HttpNetworkSession. Can we
use
> the field in params_ instead?

Done.

[Zhongyi Shi, 2017-02-22 20:34:35]

This CL is updated with the internal CL landed. This now checks RstErrorCode
received on the server side in integration test to verify the server push
cancellation. 

PTAL!

[Ryan Hamilton, 2017-02-22 23:12:33]

lgtm

https://codereview.chromium.org/2692813002/diff/180001/net/quic/core/quic_ses...
File net/quic/core/quic_session.cc (right):

https://codereview.chromium.org/2692813002/diff/180001/net/quic/core/quic_ses...
net/quic/core/quic_session.cc:99: visitor_->OnRstStreamReceived(frame);
I think this should have {}s since it's shared code. Does this match the
internal CL?

[Zhongyi Shi, 2017-02-23 00:19:46]

https://codereview.chromium.org/2692813002/diff/180001/net/quic/core/quic_ses...
File net/quic/core/quic_session.cc (right):

https://codereview.chromium.org/2692813002/diff/180001/net/quic/core/quic_ses...
net/quic/core/quic_session.cc:99: visitor_->OnRstStreamReceived(frame);
On 2017/02/22 23:12:33, Ryan Hamilton wrote:
> I think this should have {}s since it's shared code. Does this match the
> internal CL?

Sync'ed after the internal code landed. BTW, I noticed the quic_dispatcher.h is
under /core internally, should I move the chromium file to /core as well to keep
the code in sync?

[Ryan Hamilton, 2017-02-23 00:27:00]

lgtm

https://codereview.chromium.org/2692813002/diff/180001/net/quic/core/quic_ses...
File net/quic/core/quic_session.cc (right):

https://codereview.chromium.org/2692813002/diff/180001/net/quic/core/quic_ses...
net/quic/core/quic_session.cc:99: visitor_->OnRstStreamReceived(frame);
On 2017/02/23 00:19:46, Zhongyi Shi wrote:
> On 2017/02/22 23:12:33, Ryan Hamilton wrote:
> > I think this should have {}s since it's shared code. Does this match the
> > internal CL?
> 
> Sync'ed after the internal code landed. BTW, I noticed the quic_dispatcher.h
is
> under /core internally, should I move the chromium file to /core as well to
keep
> the code in sync?

No... (Though we might want to do that at some point) The current layout is that
the only files in net/quic/ are those files which are actually used in the
Chrome browser. Since the Dispatcher is server-only it can live in
net/tools/quic instead. But as we try to make the merge easier, it probably
makes sense to put all the files together in net/quic/ and make sure we're
careful about the build rules. But we can do that later...

[Buck, 2017-02-23 18:26:26]

lgtm

[Buck, 2017-02-23 18:26:27]

lgtm

[Zhongyi Shi, 2017-02-23 20:10:08]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 20:10:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 20:58:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 20:58:28]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Zhongyi Shi, 2017-02-24 00:00:16]

I forgot to fix spdy session unittests, the setup now need to set up the
enalbe_server_push_cancellation as HttpNetworkSession::SetServerPushDelegate()
will read session params to set up the push delegate if the param is enabled.

[Zhongyi Shi, 2017-02-24 00:01:20]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 00:02:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2017-02-24 00:06:06]

lgtm

[commit-bot: I haz the power, 2017-02-24 00:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 00:58:07]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Zhongyi Shi, 2017-03-02 22:15:52]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 22:16:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2017-03-02 23:41:39]

The test data files were missing on ios and caused the unittests failing, which
is now fixed. PTAL!

[commit-bot: I haz the power, 2017-03-03 00:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 00:04:19]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-03-03 00:11:18]

lgtm

[Zhongyi Shi, 2017-03-03 00:25:43]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2017-03-03 00:25:43]

The patchset sent to the CQ was uploaded after l-g-t-m from ckrasic@chromium.org
Link to the patchset: https://codereview.chromium.org/2692813002/#ps280001
(title: "Add tests files to BUILD.gn for ios usage")

[commit-bot: I haz the power, 2017-03-03 00:26:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 01:38:42]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1488500743209040,
"parent_rev": "42dc98ada07c2bcd71a992aa289147dcc83f9881", "commit_rev":
"c83d602cac3c9a7a7ef554d172b7a8cd805f13e8"}

[commit-bot: I haz the power, 2017-03-03 01:39:37]

Description was changed from

==========
Server push cancellation: add a finch trial parameter
"enable_server_push_cancellation" to control the feature of server push
cancellation. Create a HttpCacheLookupManager in HttpCache's constructor
and set it to HttpNetworkSession which will set it thru reaching
QuicChromiumClientSession and SpdySession.

BUG=232040
==========

to

==========
Server push cancellation: add a finch trial parameter
"enable_server_push_cancellation" to control the feature of server push
cancellation. Create a HttpCacheLookupManager in HttpCache's constructor
and set it to HttpNetworkSession which will set it thru reaching
QuicChromiumClientSession and SpdySession.

BUG=232040

Review-Url: https://codereview.chromium.org/2692813002
Cr-Commit-Position: refs/heads/master@{#454457}
Committed:
https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7...
==========

[commit-bot: I haz the power, 2017-03-03 01:39:39]

Committed patchset #14 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7...

[alph, 2017-03-03 10:03:49]

A revert of this CL (patchset #14 id:280001) has been created in
https://codereview.chromium.org/2730053002/ by alph@chromium.org.

The reason for reverting is: Broke MSAN
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

Is enable_server_push_cancellation initialized?.

[Zhongyi Shi, 2017-03-03 17:46:22]

Description was changed from

==========
Server push cancellation: add a finch trial parameter
"enable_server_push_cancellation" to control the feature of server push
cancellation. Create a HttpCacheLookupManager in HttpCache's constructor
and set it to HttpNetworkSession which will set it thru reaching
QuicChromiumClientSession and SpdySession.

BUG=232040

Review-Url: https://codereview.chromium.org/2692813002
Cr-Commit-Position: refs/heads/master@{#454457}
Committed:
https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7...
==========

to

==========
Server push cancellation: add a finch trial parameter
"enable_server_push_cancellation" to control the feature of server push
cancellation. Create a HttpCacheLookupManager in HttpCache's constructor
and set it to HttpNetworkSession which will set it thru reaching
QuicChromiumClientSession and SpdySession.

BUG=232040

Review-Url: https://codereview.chromium.org/2692813002
Cr-Commit-Position: refs/heads/master@{#454457}
Committed:
https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7...
==========

[Zhongyi Shi, 2017-03-03 19:30:50]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 19:31:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 20:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 20:27:20]

Dry run: This issue passed the CQ dry run.

[Zhongyi Shi, 2017-03-03 21:11:14]

Reland this cl after explicitly initialize enable_server_push_cancellation to
false. 

The previous land did pass the CQ run, but broken the MSAN which probably was
not on tryservers.

[Zhongyi Shi, 2017-03-03 21:17:48]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2017-03-03 21:17:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
ckrasic@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2692813002/#ps300001
(title: "explicitly initialize the enable_server_push_cancellation to false")

[commit-bot: I haz the power, 2017-03-03 21:18:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 21:23:51]

CQ is committing da patch.

Bot data: {"patchset_id": 300001, "attempt_start_ts": 1488575868862300,
"parent_rev": "f4adeaac49556e68664aac66b2f2fb95d7fddf0e", "commit_rev":
"f04bd2c84154b59a3d870993051df4be0b13964f"}

[commit-bot: I haz the power, 2017-03-03 21:24:56]

Description was changed from

==========
Server push cancellation: add a finch trial parameter
"enable_server_push_cancellation" to control the feature of server push
cancellation. Create a HttpCacheLookupManager in HttpCache's constructor
and set it to HttpNetworkSession which will set it thru reaching
QuicChromiumClientSession and SpdySession.

BUG=232040

Review-Url: https://codereview.chromium.org/2692813002
Cr-Commit-Position: refs/heads/master@{#454457}
Committed:
https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7...
==========

to

==========
Server push cancellation: add a finch trial parameter
"enable_server_push_cancellation" to control the feature of server push
cancellation. Create a HttpCacheLookupManager in HttpCache's constructor
and set it to HttpNetworkSession which will set it thru reaching
QuicChromiumClientSession and SpdySession.

BUG=232040

Review-Url: https://codereview.chromium.org/2692813002
Cr-Original-Commit-Position: refs/heads/master@{#454457}
Committed:
https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7...
Review-Url: https://codereview.chromium.org/2692813002
Cr-Commit-Position: refs/heads/master@{#454679}
Committed:
https://chromium.googlesource.com/chromium/src/+/f04bd2c84154b59a3d870993051d...
==========

[commit-bot: I haz the power, 2017-03-03 21:24:57]

Committed patchset #15 (id:300001) as
https://chromium.googlesource.com/chromium/src/+/f04bd2c84154b59a3d870993051d...

[sclittle, 2017-03-03 23:22:52]

A revert of this CL (patchset #15 id:300001) has been created in
https://codereview.chromium.org/2728183003/ by sclittle@chromium.org.

The reason for reverting is: Broke net_unittests on Win7 (dbg) bot:

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%...

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%....

[Zhongyi Shi, 2017-03-03 23:28:53]

Description was changed from

==========
Server push cancellation: add a finch trial parameter
"enable_server_push_cancellation" to control the feature of server push
cancellation. Create a HttpCacheLookupManager in HttpCache's constructor
and set it to HttpNetworkSession which will set it thru reaching
QuicChromiumClientSession and SpdySession.

BUG=232040

Review-Url: https://codereview.chromium.org/2692813002
Cr-Original-Commit-Position: refs/heads/master@{#454457}
Committed:
https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7...
Review-Url: https://codereview.chromium.org/2692813002
Cr-Commit-Position: refs/heads/master@{#454679}
Committed:
https://chromium.googlesource.com/chromium/src/+/f04bd2c84154b59a3d870993051d...
==========

to

==========
Server push cancellation: add a finch trial parameter
"enable_server_push_cancellation" to control the feature of server push
cancellation. Create a HttpCacheLookupManager in HttpCache's constructor
and set it to HttpNetworkSession which will set it thru reaching
QuicChromiumClientSession and SpdySession.

BUG=232040

Review-Url: https://codereview.chromium.org/2692813002
Cr-Original-Commit-Position: refs/heads/master@{#454457}
Committed:
https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7...
Review-Url: https://codereview.chromium.org/2692813002
Cr-Commit-Position: refs/heads/master@{#454679}
Committed:
https://chromium.googlesource.com/chromium/src/+/f04bd2c84154b59a3d870993051d...
==========

[Zhongyi Shi, 2017-03-07 00:14:12]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 00:14:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 03:11:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 03:11:16]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Zhongyi Shi, 2017-03-07 19:14:07]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 19:15:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2017-03-07 21:23:53]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 21:24:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 23:59:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 23:59:54]

Dry run: This issue passed the CQ dry run.

[Zhongyi Shi, 2017-03-08 00:51:17]

Patchset #16 (id:320001) has been deleted

[Zhongyi Shi, 2017-03-08 01:06:32]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 01:07:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 02:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 02:12:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhongyi Shi, 2017-03-10 22:50:49]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 22:51:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 00:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 00:07:13]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-04-04 19:22:03]

zhongyi: is this ready to re-land?

[Zhongyi Shi, 2017-04-05 00:09:08]

On 2017/04/04 19:22:03, Ryan Hamilton wrote:
> zhongyi: is this ready to re-land?

Not really. I am getting back to this issue to fix the integration test failure
on Windows due to early shutdown of the test server.

[Zhongyi Shi, 2017-04-11 19:29:24]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 19:30:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 19:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 19:34:01]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Zhongyi Shi, 2017-04-11 22:07:38]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 22:08:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 00:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 00:51:56]

Dry run: This issue passed the CQ dry run.

[Zhongyi Shi, 2017-04-14 01:04:55]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 01:05:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 02:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 02:18:03]

Dry run: This issue passed the CQ dry run.

[Zhongyi Shi, 2017-04-14 16:47:15]

The integration test failure on windows was caused by indefinite order of
response. The new patch set spins the message loop until the response for the
first request has been received, and then proceed to send the second request.
win_chromium_dbg_ng bot has been run to ensure the tests passed on Win7.

[Zhongyi Shi, 2017-04-14 16:54:35]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2017-04-14 16:54:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
ckrasic@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2692813002/#ps460001
(title: "Spin the message loop to ensure the client receives the response")

[commit-bot: I haz the power, 2017-04-14 16:54:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 17:01:30]

CQ is committing da patch.

Bot data: {"patchset_id": 460001, "attempt_start_ts": 1492188875262820,
"parent_rev": "de84c46351bdfb8d16c587c7a568dbb5250da734", "commit_rev":
"d7dd2db1ad3596d682aa7fd56d3fef6f218250ec"}

[commit-bot: I haz the power, 2017-04-14 17:03:17]

Description was changed from

==========
Server push cancellation: add a finch trial parameter
"enable_server_push_cancellation" to control the feature of server push
cancellation. Create a HttpCacheLookupManager in HttpCache's constructor
and set it to HttpNetworkSession which will set it thru reaching
QuicChromiumClientSession and SpdySession.

BUG=232040

Review-Url: https://codereview.chromium.org/2692813002
Cr-Original-Commit-Position: refs/heads/master@{#454457}
Committed:
https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7...
Review-Url: https://codereview.chromium.org/2692813002
Cr-Commit-Position: refs/heads/master@{#454679}
Committed:
https://chromium.googlesource.com/chromium/src/+/f04bd2c84154b59a3d870993051d...
==========

to

==========
Server push cancellation: add a finch trial parameter
"enable_server_push_cancellation" to control the feature of server push
cancellation. Create a HttpCacheLookupManager in HttpCache's constructor
and set it to HttpNetworkSession which will set it thru reaching
QuicChromiumClientSession and SpdySession.

BUG=232040

Review-Url: https://codereview.chromium.org/2692813002
Cr-Original-Original-Commit-Position: refs/heads/master@{#454457}
Committed:
https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7...
Review-Url: https://codereview.chromium.org/2692813002
Cr-Original-Commit-Position: refs/heads/master@{#454679}
Committed:
https://chromium.googlesource.com/chromium/src/+/f04bd2c84154b59a3d870993051d...
Review-Url: https://codereview.chromium.org/2692813002
Cr-Commit-Position: refs/heads/master@{#464737}
Committed:
https://chromium.googlesource.com/chromium/src/+/d7dd2db1ad3596d682aa7fd56d3f...
==========

[commit-bot: I haz the power, 2017-04-14 17:03:18]

Committed patchset #22 (id:460001) as
https://chromium.googlesource.com/chromium/src/+/d7dd2db1ad3596d682aa7fd56d3f...