Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2751623002: Revert of Server push cancellation: add a finch trial parameter (patchset #14 id:280001 of https://… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/network_session_configurator/network_session_configurator.h " 5 #include "components/network_session_configurator/network_session_configurator.h "
6 6
7 #include <map> 7 #include <map>
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 ParseFieldTrials(); 67 ParseFieldTrials();
68 68
69 EXPECT_TRUE(params_.enable_quic); 69 EXPECT_TRUE(params_.enable_quic);
70 EXPECT_FALSE(params_.disable_quic_on_timeout_with_open_streams); 70 EXPECT_FALSE(params_.disable_quic_on_timeout_with_open_streams);
71 EXPECT_EQ(1350u, params_.quic_max_packet_length); 71 EXPECT_EQ(1350u, params_.quic_max_packet_length);
72 EXPECT_EQ(net::QuicTagVector(), params_.quic_connection_options); 72 EXPECT_EQ(net::QuicTagVector(), params_.quic_connection_options);
73 EXPECT_FALSE(params_.quic_always_require_handshake_confirmation); 73 EXPECT_FALSE(params_.quic_always_require_handshake_confirmation);
74 EXPECT_FALSE(params_.quic_disable_connection_pooling); 74 EXPECT_FALSE(params_.quic_disable_connection_pooling);
75 EXPECT_EQ(0.25f, params_.quic_load_server_info_timeout_srtt_multiplier); 75 EXPECT_EQ(0.25f, params_.quic_load_server_info_timeout_srtt_multiplier);
76 EXPECT_FALSE(params_.quic_enable_connection_racing); 76 EXPECT_FALSE(params_.quic_enable_connection_racing);
77 EXPECT_FALSE(params_.enable_server_push_cancellation);
78 EXPECT_FALSE(params_.quic_enable_non_blocking_io); 77 EXPECT_FALSE(params_.quic_enable_non_blocking_io);
79 EXPECT_FALSE(params_.quic_disable_disk_cache); 78 EXPECT_FALSE(params_.quic_disable_disk_cache);
80 EXPECT_FALSE(params_.quic_prefer_aes); 79 EXPECT_FALSE(params_.quic_prefer_aes);
81 EXPECT_TRUE(params_.enable_quic_alternative_service_with_different_host); 80 EXPECT_TRUE(params_.enable_quic_alternative_service_with_different_host);
82 EXPECT_TRUE(params_.quic_delay_tcp_race); 81 EXPECT_TRUE(params_.quic_delay_tcp_race);
83 EXPECT_FALSE(params_.quic_close_sessions_on_ip_change); 82 EXPECT_FALSE(params_.quic_close_sessions_on_ip_change);
84 EXPECT_EQ(net::kIdleConnectionTimeoutSeconds, 83 EXPECT_EQ(net::kIdleConnectionTimeoutSeconds,
85 params_.quic_idle_connection_timeout_seconds); 84 params_.quic_idle_connection_timeout_seconds);
86 EXPECT_EQ(net::kPingTimeoutSecs, params_.quic_reduced_ping_timeout_seconds); 85 EXPECT_EQ(net::kPingTimeoutSecs, params_.quic_reduced_ping_timeout_seconds);
87 EXPECT_EQ(net::kQuicYieldAfterDurationMilliseconds, 86 EXPECT_EQ(net::kQuicYieldAfterDurationMilliseconds,
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 std::map<std::string, std::string> field_trial_params; 203 std::map<std::string, std::string> field_trial_params;
205 field_trial_params["race_cert_verification"] = "true"; 204 field_trial_params["race_cert_verification"] = "true";
206 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params); 205 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
207 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled"); 206 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
208 207
209 ParseFieldTrials(); 208 ParseFieldTrials();
210 209
211 EXPECT_TRUE(params_.quic_race_cert_verification); 210 EXPECT_TRUE(params_.quic_race_cert_verification);
212 } 211 }
213 212
214 TEST_F(NetworkSessionConfiguratorTest, EnableServerPushCancellation) {
215 std::map<std::string, std::string> field_trial_params;
216 field_trial_params["enable_server_push_cancellation"] = "true";
217 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
218 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
219
220 ParseFieldTrials();
221
222 EXPECT_TRUE(params_.enable_server_push_cancellation);
223 }
224
225 TEST_F(NetworkSessionConfiguratorTest, QuicDoNotFragment) { 213 TEST_F(NetworkSessionConfiguratorTest, QuicDoNotFragment) {
226 std::map<std::string, std::string> field_trial_params; 214 std::map<std::string, std::string> field_trial_params;
227 field_trial_params["do_not_fragment"] = "true"; 215 field_trial_params["do_not_fragment"] = "true";
228 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params); 216 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
229 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled"); 217 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
230 218
231 ParseFieldTrials(); 219 ParseFieldTrials();
232 220
233 EXPECT_TRUE(params_.quic_do_not_fragment); 221 EXPECT_TRUE(params_.quic_do_not_fragment);
234 } 222 }
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 field_trial_params["force_hol_blocking"] = "true"; 477 field_trial_params["force_hol_blocking"] = "true";
490 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params); 478 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
491 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled"); 479 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
492 480
493 ParseFieldTrials(); 481 ParseFieldTrials();
494 482
495 EXPECT_TRUE(params_.quic_force_hol_blocking); 483 EXPECT_TRUE(params_.quic_force_hol_blocking);
496 } 484 }
497 485
498 } // namespace test 486 } // namespace test
OLDNEW
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698