Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2730053002: Revert of Server push cancellation: add a finch trial parameter (Closed)

Created:
3 years, 9 months ago by alph
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Server push cancellation: add a finch trial parameter (patchset #14 id:280001 of https://codereview.chromium.org/2692813002/ ) Reason for revert: Broke MSAN https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/698 Is enable_server_push_cancellation initialized? Original issue's description: > Server push cancellation: add a finch trial parameter > "enable_server_push_cancellation" to control the feature of server push > cancellation. Create a HttpCacheLookupManager in HttpCache's constructor > and set it to HttpNetworkSession which will set it thru reaching > QuicChromiumClientSession and SpdySession. > > BUG=232040 > > Review-Url: https://codereview.chromium.org/2692813002 > Cr-Commit-Position: refs/heads/master@{#454457} > Committed: https://chromium.googlesource.com/chromium/src/+/c83d602cac3c9a7a7ef554d172b7a8cd805f13e8 TBR=rch@chromium.org,ckrasic@chromium.org,zhongyi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=232040 Review-Url: https://codereview.chromium.org/2730053002 Cr-Commit-Position: refs/heads/master@{#454554} Committed: https://chromium.googlesource.com/chromium/src/+/cfb060c669c937702a4ede2d59ae71ae48aafdc3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -330 lines) Patch
M components/network_session_configurator/network_session_configurator.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M net/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_cache.cc View 2 chunks +8 lines, -15 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_dispatcher.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/tools/quic/quic_simple_dispatcher.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_session_visitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_quic_unittest.cc View 6 chunks +0 lines, -230 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
alph
Created Revert of Server push cancellation: add a finch trial parameter
3 years, 9 months ago (2017-03-03 10:03:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730053002/1
3 years, 9 months ago (2017-03-03 10:04:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cfb060c669c937702a4ede2d59ae71ae48aafdc3
3 years, 9 months ago (2017-03-03 10:05:39 UTC) #6
Zhongyi Shi
3 years, 9 months ago (2017-03-03 19:34:59 UTC) #7
Message was sent while issue was closed.
lgtm

Is MSAN
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...
on tryserver?

I wonder why tryserver didn't catch this. I should explicitly initialize the
var, which got missed when moving the var around. Thanks for helping revert the
cl.

Powered by Google App Engine
This is Rietveld 408576698