Issue 2751083002: Revert "[kernel] offsets on direct property get/set"

Issue 2751083002: Revert "[kernel] offsets on direct property get/set" (Closed)

Created:
3 years, 9 months ago by jensj

Modified:
3 years, 9 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, dart-fe-team+reviews_google.com, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "[kernel] offsets on direct property get/set" This commit wanted stuff from anther CL that haven't landed yet. This reverts commit 7577f6aaa052c9a1c309f13bf338b92bf4fb9fd0. BUG= Committed: https://github.com/dart-lang/sdk/commit/9fa510ea38bf0f9b5aca87ffa4fab9a8daf12e66

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -183 lines)			Patch
M	pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart	View	1 chunk	+6 lines, -8 lines	0 comments	Download
M	pkg/kernel/binary.md	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/kernel/lib/binary/ast_from_binary.dart	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	pkg/kernel/lib/binary/ast_to_binary.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/kernel/lib/transformations/mixin_full_resolution.dart	View	2 chunks	+2 lines, -4 lines	0 comments	Download
D	runtime/observatory/tests/service/step_through_property_get_test.dart	View	1 chunk	+0 lines, -78 lines	0 comments	Download
D	runtime/observatory/tests/service/step_through_property_set_test.dart	View	1 chunk	+0 lines, -78 lines	0 comments	Download
M	runtime/vm/kernel_binary.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (2 generated)

jensj

3 years, 9 months ago (2017-03-15 12:54:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9fa510ea38bf0f9b5aca87ffa4fab9a8daf12e66 (presubmit successful).