Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2601)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart

Issue 2751083002: Revert "[kernel] offsets on direct property get/set" (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
index d508b8f5ba6c8f898754aa98493c0dc2e07d266e..50658378e4e55d873045e76eb43bf29f18fa089a 100644
--- a/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
@@ -216,10 +216,10 @@ class ThisAccessor extends BuilderAccessor {
Member getter = helper.lookupSuperMember(send.name);
Member setter = helper.lookupSuperMember(send.name, isSetter: true);
return new SuperPropertyAccessor(
- helper, send.charOffset, send.name, getter, setter);
+ helper, charOffset, send.name, getter, setter);
} else {
return new ThisPropertyAccessor(
- helper, send.charOffset, send.name, null, null);
+ helper, charOffset, send.name, null, null);
}
}
}
@@ -592,9 +592,11 @@ class SuperPropertyAccessor extends kernel.SuperPropertyAccessor
with BuilderAccessor {
final BuilderHelper helper;
+ final int charOffset;
+
SuperPropertyAccessor(
- this.helper, int charOffset, Name name, Member getter, Member setter)
- : super(name, getter, setter, charOffset);
+ this.helper, this.charOffset, Name name, Member getter, Member setter)
+ : super(name, getter, setter);
String get plainNameForRead => name.name;
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698